From c5c0dd98eb145e764d0481e40382bfffe9d64aa9 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 18:09:18 +0200 Subject: [PATCH 01/23] Fix binaryen build in build.yml --- .github/workflows/build.yml | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5c5e4019..9d353985 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,16 +15,15 @@ jobs: runs-on: ubuntu-latest if: github.event_name == 'schedule' || !contains(github.event.head_commit.message, '[ci skip]') env: - MAKE_FLAGS: "-j2" CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE" strategy: matrix: emsdk: [ "tot", "latest" ] fail-fast: false steps: - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v6 with: - node-version: '20' + node-version: '22' - name: "Set up Emsdk" run: | mkdir $HOME/emsdk @@ -34,12 +33,12 @@ jobs: $HOME/emsdk/emsdk activate ${{ matrix.emsdk }} echo "$HOME/emsdk" >> $GITHUB_PATH - name: "Set up CMake" - run: | - mkdir $HOME/cmake - wget -qO- https://github.com/Kitware/CMake/releases/download/v3.21.4/cmake-3.21.4-Linux-x86_64.tar.gz | tar -xzC $HOME/cmake --strip-components 1 - echo "$HOME/cmake/bin" >> $GITHUB_PATH + uses: lukka/get-cmake@v3.31.0 + with: + cmakeVersion: 3.30.5 + ninjaVersion: latest - name: "Check out repository" - uses: actions/checkout@v1 + uses: actions/checkout@v4 with: submodules: false - name: "Set up repository" @@ -79,12 +78,12 @@ jobs: fi - name: "Build binaryen.js" run: | - mkdir ./binaryen/build + mkdir -p ./binaryen/build cd ./binaryen/build source $HOME/emsdk/emsdk_env.sh emcc --version - emcmake cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" -DENABLE_WERROR=OFF - emmake make $MAKE_FLAGS binaryen_wasm + emcmake cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" -DENABLE_WERROR=OFF + emmake ninja cd ../.. npm run bundle - name: "Test binaryen.js" @@ -95,9 +94,11 @@ jobs: mkdir -p ./bin cd ./binaryen/build source $HOME/emsdk/emsdk_env.sh - emcc --version for tool in ${{ env.BINARYEN_TOOLS }}; do - emmake make $MAKE_FLAGS "$tool" + if [ ! -f "./bin/$tool.js" ]; then + echo "Missing tool: $tool" + exit 1 + fi echo '#!/usr/bin/env node' > "../../bin/$tool" cat "./bin/$tool.js" >> "../../bin/$tool" done From 3e1b7e3eb8282fc4c53fe6c65c3411c48436984f Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 18:37:07 +0200 Subject: [PATCH 02/23] Apply suggestion from @MaxGraey don't build tests --- .github/workflows/build.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9d353985..ce7d8ebe 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,7 +82,13 @@ jobs: cd ./binaryen/build source $HOME/emsdk/emsdk_env.sh emcc --version - emcmake cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" -DENABLE_WERROR=OFF + emcmake cmake .. -G Ninja \ + -DCMAKE_BUILD_TYPE=Release \ + -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" \ + -DENABLE_WERROR=OFF \ + -DBUILD_TOOLS=ON \ + -DBUILD_STATIC_LIB=OFF \ + -DBUILD_TESTS=OFF emmake ninja cd ../.. npm run bundle From f4691bebaee7e84fdf790c597d4c7e792b36506b Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:06:21 +0200 Subject: [PATCH 03/23] Fix closure exported symbols --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ce7d8ebe..d4a1e3cd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest if: github.event_name == 'schedule' || !contains(github.event.head_commit.message, '[ci skip]') env: - CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE" + CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE -sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii,getExceptionMessage" strategy: matrix: emsdk: [ "tot", "latest" ] From 931fb7f345f5bb1d7816299e00d32865136ef592 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:06:47 +0200 Subject: [PATCH 04/23] skip build fuzzing --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d4a1e3cd..d1938eca 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -88,7 +88,8 @@ jobs: -DENABLE_WERROR=OFF \ -DBUILD_TOOLS=ON \ -DBUILD_STATIC_LIB=OFF \ - -DBUILD_TESTS=OFF + -DBUILD_TESTS=OFF \ + -DBUILD_FUZZING=OFF emmake ninja cd ../.. npm run bundle From 8600c2ca0e2d65a6a720bda4061af73a2d35cd24 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:18:33 +0200 Subject: [PATCH 05/23] Apply suggestion from @MaxGraey update options for cmake --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d1938eca..f9a646e3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -86,10 +86,12 @@ jobs: -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" \ -DENABLE_WERROR=OFF \ + -DEMSCRIPTEN_ENABLE_SINGLE_FILE=ON \ + -DBUILD_EMSCRIPTEN_TOOLS_ONLY=ON \ -DBUILD_TOOLS=ON \ -DBUILD_STATIC_LIB=OFF \ -DBUILD_TESTS=OFF \ - -DBUILD_FUZZING=OFF + -DBUILD_FUZZTEST=OFF emmake ninja cd ../.. npm run bundle From 605390c61c80c94a425aa3c618a0077892c23d0f Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:30:09 +0200 Subject: [PATCH 06/23] fix? --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f9a646e3..f6176b11 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -91,7 +91,8 @@ jobs: -DBUILD_TOOLS=ON \ -DBUILD_STATIC_LIB=OFF \ -DBUILD_TESTS=OFF \ - -DBUILD_FUZZTEST=OFF + -DBUILD_FUZZTEST=OFF \ + -DThreads_FOUND=TRUE emmake ninja cd ../.. npm run bundle From 9659c9bfc86433bbec2ac792d68d84077a2530fc Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:45:04 +0200 Subject: [PATCH 07/23] fix? --- .github/workflows/build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f6176b11..370e4d23 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -86,13 +86,10 @@ jobs: -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" \ -DENABLE_WERROR=OFF \ - -DEMSCRIPTEN_ENABLE_SINGLE_FILE=ON \ -DBUILD_EMSCRIPTEN_TOOLS_ONLY=ON \ -DBUILD_TOOLS=ON \ - -DBUILD_STATIC_LIB=OFF \ -DBUILD_TESTS=OFF \ - -DBUILD_FUZZTEST=OFF \ - -DThreads_FOUND=TRUE + -DBUILD_FUZZTEST=OFF emmake ninja cd ../.. npm run bundle From 54d03245579d490d984c4774280c456a835097e6 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 19:45:57 +0200 Subject: [PATCH 08/23] use latest lukkas action --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 370e4d23..84bc86a1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -33,7 +33,7 @@ jobs: $HOME/emsdk/emsdk activate ${{ matrix.emsdk }} echo "$HOME/emsdk" >> $GITHUB_PATH - name: "Set up CMake" - uses: lukka/get-cmake@v3.31.0 + uses: lukka/get-cmake@latest with: cmakeVersion: 3.30.5 ninjaVersion: latest From 82511f1064e2dd4a248ef721e3b7aab5d96d6ed4 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:02:55 +0200 Subject: [PATCH 09/23] try donwgrade cmkae ver --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 84bc86a1..4f9aee4e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -35,7 +35,7 @@ jobs: - name: "Set up CMake" uses: lukka/get-cmake@latest with: - cmakeVersion: 3.30.5 + cmakeVersion: 3.27.9 ninjaVersion: latest - name: "Check out repository" uses: actions/checkout@v4 From 84c83f1efc66231a7d4afb7443022f2350e9e882 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:15:39 +0200 Subject: [PATCH 10/23] remove sEXPORTED_RUNTIME_METHODS --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4f9aee4e..5cf16afa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest if: github.event_name == 'schedule' || !contains(github.event.head_commit.message, '[ci skip]') env: - CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE -sEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii,getExceptionMessage" + CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE" strategy: matrix: emsdk: [ "tot", "latest" ] From 5574c27d6c406bb7540fb155e9cac397c2d4a7b4 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:19:34 +0200 Subject: [PATCH 11/23] update cmkae version --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5cf16afa..d740b84d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -35,7 +35,7 @@ jobs: - name: "Set up CMake" uses: lukka/get-cmake@latest with: - cmakeVersion: 3.27.9 + cmakeVersion: 3.31.11 ninjaVersion: latest - name: "Check out repository" uses: actions/checkout@v4 From 67a1e0149d40e578af6505dfdbca6a05ad702de6 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:24:18 +0200 Subject: [PATCH 12/23] remove wasm-shell tool --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d740b84d..0f9abd76 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -8,7 +8,7 @@ on: - main pull_request: env: - BINARYEN_TOOLS: wasm-shell wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce wasm-merge + BINARYEN_TOOLS: wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce wasm-merge jobs: build: name: "Build with Emsdk:${{ matrix.emsdk }}" From d119579cd0527e6d4a8492bd70de8e64c4aa9402 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:25:20 +0200 Subject: [PATCH 13/23] remove wasm-merge --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0f9abd76..a5163b39 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -8,7 +8,7 @@ on: - main pull_request: env: - BINARYEN_TOOLS: wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce wasm-merge + BINARYEN_TOOLS: wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce jobs: build: name: "Build with Emsdk:${{ matrix.emsdk }}" From 15373294b565adec8c6db37af88bd4f171b64009 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:39:41 +0200 Subject: [PATCH 14/23] add BUILD_STATIC_LIB=OFF flag for cmake --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a5163b39..afa0bdcc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -88,6 +88,7 @@ jobs: -DENABLE_WERROR=OFF \ -DBUILD_EMSCRIPTEN_TOOLS_ONLY=ON \ -DBUILD_TOOLS=ON \ + -DBUILD_STATIC_LIB=OFF \ -DBUILD_TESTS=OFF \ -DBUILD_FUZZTEST=OFF emmake ninja From cb636257a2fbf18fd02f19a0b62d59cf74360585 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 28 Mar 2026 20:51:12 +0200 Subject: [PATCH 15/23] try to add DEXPORTED_RUNTIME_METHODS for cmake --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index afa0bdcc..40e3d9d3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -85,6 +85,7 @@ jobs: emcmake cmake .. -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" \ + -DEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii,getExceptionMessage \ -DENABLE_WERROR=OFF \ -DBUILD_EMSCRIPTEN_TOOLS_ONLY=ON \ -DBUILD_TOOLS=ON \ From 9a37246a0e93513e592c1bffe98339b5df9d9278 Mon Sep 17 00:00:00 2001 From: CountBleck Date: Sun, 29 Mar 2026 11:07:11 -0700 Subject: [PATCH 16/23] chore: publish to npm via OIDC --- .github/workflows/build.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 40e3d9d3..c3b8de8a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -14,6 +14,9 @@ jobs: name: "Build with Emsdk:${{ matrix.emsdk }}" runs-on: ubuntu-latest if: github.event_name == 'schedule' || !contains(github.event.head_commit.message, '[ci skip]') + permissions: + id-token: write + contents: write env: CMAKE_EXE_LINKER_FLAGS: "-sMAXIMUM_MEMORY=4294967296 -sSINGLE_FILE" strategy: @@ -137,11 +140,7 @@ jobs: git push -u origin "v$VERSION" - name: "Publish to npm" if: github.event_name == 'schedule' && matrix.emsdk == 'tot' - env: - NPM_REGISTRY: "registry.npmjs.org" - NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} run: | - npm config set "//${NPM_REGISTRY}/:_authToken=${NPM_AUTH_TOKEN}" if [ $RELEASE ]; then echo "Publishing release ..." npm publish From a7af9c34b5ed8de20aa425013b781174340a7bd3 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sun, 29 Mar 2026 21:37:16 +0300 Subject: [PATCH 17/23] Try to force update submodules. Restore some changes --- .github/workflows/build.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c3b8de8a..2c9d8fb0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -8,7 +8,7 @@ on: - main pull_request: env: - BINARYEN_TOOLS: wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce + BINARYEN_TOOLS: wasm-shell wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce wasm-merge jobs: build: name: "Build with Emsdk:${{ matrix.emsdk }}" @@ -43,7 +43,7 @@ jobs: - name: "Check out repository" uses: actions/checkout@v4 with: - submodules: false + submodules: true - name: "Set up repository" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -88,9 +88,7 @@ jobs: emcmake cmake .. -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_EXE_LINKER_FLAGS="$CMAKE_EXE_LINKER_FLAGS" \ - -DEXPORTED_RUNTIME_METHODS=stringToUTF8OnStack,stringToAscii,getExceptionMessage \ -DENABLE_WERROR=OFF \ - -DBUILD_EMSCRIPTEN_TOOLS_ONLY=ON \ -DBUILD_TOOLS=ON \ -DBUILD_STATIC_LIB=OFF \ -DBUILD_TESTS=OFF \ From 3ad07ee224723cdf089c8decf821fd3a39bbf9c9 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sun, 29 Mar 2026 21:51:50 +0300 Subject: [PATCH 18/23] Fix? --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2c9d8fb0..60ce35d7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,7 +56,7 @@ jobs: # If not a PR, undo detached head git checkout "${GITHUB_REF:11}" fi - git submodule update --init --remote --merge --recursive + git submodule update --init --remote --recursive cd ./binaryen git log -n1 cd .. From 0a825f85223bb8777a264fe43a95c8ddee662fa0 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sun, 29 Mar 2026 23:03:14 +0300 Subject: [PATCH 19/23] rename binaryen_js to binaryen_wasm --- .github/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 60ce35d7..fa681f5b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -95,6 +95,8 @@ jobs: -DBUILD_FUZZTEST=OFF emmake ninja cd ../.. + cp ./binaryen/build/bin/binaryen_js.js ./binaryen/build/bin/binaryen_wasm.js + cp ./binaryen/build/bin/binaryen_js.wasm ./binaryen/build/bin/binaryen_wasm.wasm npm run bundle - name: "Test binaryen.js" run: | From 93f94e10f80a02dcb0190a413bc78f94d8a14ee4 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sun, 29 Mar 2026 23:46:41 +0300 Subject: [PATCH 20/23] fix --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fa681f5b..b7e81f7c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -95,8 +95,7 @@ jobs: -DBUILD_FUZZTEST=OFF emmake ninja cd ../.. - cp ./binaryen/build/bin/binaryen_js.js ./binaryen/build/bin/binaryen_wasm.js - cp ./binaryen/build/bin/binaryen_js.wasm ./binaryen/build/bin/binaryen_wasm.wasm + mv ./binaryen/build/bin/binaryen_js.js ./binaryen/build/bin/binaryen_wasm.js npm run bundle - name: "Test binaryen.js" run: | From fb29d592810c24aa5d546ab8fbc379b0beff2da6 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Mon, 30 Mar 2026 02:59:56 +0300 Subject: [PATCH 21/23] remove some redundant commans --- .github/workflows/build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b7e81f7c..f2442174 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -71,7 +71,6 @@ jobs: echo "Resetting to $TAG ..." cd ./binaryen git reset --hard "$TAG" - git clean -f git log -n1 cd .. echo "RELEASE=1" >> $GITHUB_ENV @@ -83,7 +82,6 @@ jobs: run: | mkdir -p ./binaryen/build cd ./binaryen/build - source $HOME/emsdk/emsdk_env.sh emcc --version emcmake cmake .. -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ @@ -104,7 +102,6 @@ jobs: run: | mkdir -p ./bin cd ./binaryen/build - source $HOME/emsdk/emsdk_env.sh for tool in ${{ env.BINARYEN_TOOLS }}; do if [ ! -f "./bin/$tool.js" ]; then echo "Missing tool: $tool" @@ -112,9 +109,9 @@ jobs: fi echo '#!/usr/bin/env node' > "../../bin/$tool" cat "./bin/$tool.js" >> "../../bin/$tool" + chmod +x "../../bin/$tool" done cd ../.. - chmod +x ./bin/* - name: "Test tools" run: | for tool in ${{ env.BINARYEN_TOOLS }}; do From 7eaec492fdb225364aaf7733606f6ac3bc34d6ba Mon Sep 17 00:00:00 2001 From: Max Graey Date: Mon, 30 Mar 2026 03:11:26 +0300 Subject: [PATCH 22/23] Minor tweaks. Add pipeline cancelation --- .github/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f2442174..8b179146 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,6 +9,9 @@ on: pull_request: env: BINARYEN_TOOLS: wasm-shell wasm-opt wasm-metadce wasm2js wasm-as wasm-dis wasm-ctor-eval wasm-reduce wasm-merge +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true jobs: build: name: "Build with Emsdk:${{ matrix.emsdk }}" @@ -56,7 +59,7 @@ jobs: # If not a PR, undo detached head git checkout "${GITHUB_REF:11}" fi - git submodule update --init --remote --recursive + git submodule update --init --remote --recursive --depth 1 cd ./binaryen git log -n1 cd .. From 3946d8ac3bf43c01a4880a60f0060a8f3cacc3ea Mon Sep 17 00:00:00 2001 From: Max Graey Date: Mon, 30 Mar 2026 03:23:04 +0300 Subject: [PATCH 23/23] revert source $HOME/emsdk/emsdk_env.sh --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8b179146..b2b05226 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -85,6 +85,7 @@ jobs: run: | mkdir -p ./binaryen/build cd ./binaryen/build + source $HOME/emsdk/emsdk_env.sh emcc --version emcmake cmake .. -G Ninja \ -DCMAKE_BUILD_TYPE=Release \