[PWGJE,Infrastructure] Create qg tree creator by Physicistdana · Pull Request #15555 · AliceO2Group/O2Physics

Physicistdana · 2026-03-28T04:38:17Z

Jet analysis code

PWGJE/Tasks/qgTreeCreator.cxx

vkucera · 2026-03-28T20:38:22Z

PWGJE/Tasks/qgTreeCreator.cxx

+  return std::remainder(phi1 - phi2, 2.f * static_cast<float>(M_PI));
+}
+
+float deltaR(float eta1, float phi1, float eta2, float phi2)


Isn't this an existing method?

PWGJE/Tasks/qgTreeCreator.cxx

vkucera · 2026-03-29T10:52:11Z

Hi @Physicistdana , please:

Get familiar with the contribution guidelines.
Mention your name on your GitHub account. (How can we know who you are?)
Name your fork repository the same as the main one, i.e. "O2Physics".
Don't open your PR as ready for review if it doesn't pass the formatting check.
Don't include unrelated changes in your PR, like modifying the .github directory.
Don't scatter your modifications across many commits.
Give your commits meaningful titles.

vkucera · 2026-03-29T10:55:40Z

PWGJE/Tasks/qgTreeCreator.cxx

+constexpr int kGluon = 21;
+constexpr int kQuarkMin = 1;
+constexpr int kQuarkMax = 6;


Use existing constants.

vkucera · 2026-03-29T10:56:03Z

PWGJE/Tasks/qgTreeCreator.cxx

+// or submit itself to any jurisdiction.
+#include "PWGJE/DataModel/Jet.h"
+#include "PWGJE/DataModel/JetMatching.h"


Add Doxygen documentation.

nzardosh · 2026-03-30T08:28:51Z

PWGJE/Tasks/qgTreeCreator.cxx

+// find initiating parton by ancestry
+//------------------------------------------------
+int getInitiatingParton(auto const& particle,
+                        aod::McParticles const& mcParticles)


please use the derived tables such as JetParticles

nzardosh · 2026-03-30T08:29:57Z

PWGJE/Tasks/qgTreeCreator.cxx

+    const int mpdg = mom.pdgCode();
+
+    if (std::abs(mpdg) == kGluon ||
+        (std::abs(mpdg) >= kQuarkMin && std::abs(mpdg) <= kQuarkMax)) {


what happens in the case of g->qqbar? you wrongly get a q as the mother whereas it should be a g

nzardosh · 2026-03-30T08:30:55Z

PWGJE/Tasks/qgTreeCreator.cxx

+  void process(aod::ChargedMCDetectorLevelJets const& recoJets,
+               aod::ChargedMCParticleLevelJets const& truthJets,
+               aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets const& matches,
+               aod::McParticles const& mcParticles)


use the derived tables

nzardosh · 2026-03-30T08:31:51Z

PWGJE/Tasks/qgTreeCreator.cxx

+          qg = 1;
+        } else if (std::abs(pdg) >= kQuarkMin && std::abs(pdg) <= kQuarkMax) {
+          qg = 0;
+      }


the indentations look wrong somehow

nzardosh · 2026-03-30T08:32:44Z

PWGJE/Tasks/qgTreeCreator.cxx

+        int pdg = 0;
+
+        for (auto const& tc :
+             truthJet.tracks_as<aod::ChargedMCParticleLevelJetConstituent>()) {


this is not correct, as the table given here should be JetParticles. Does this even compile?

nzardosh · 2026-03-30T08:35:33Z

PWGJE/Tasks/qgTreeCreator.cxx

+      float sumPt2 = 0;
+      float sumPtDr = 0;
+
+      for (auto const& c : jet.tracks_as<aod::ChargedMCDetectorLevelJetConstituent>()) {


here the table is wrong too, please see below

nzardosh · 2026-03-30T08:36:04Z

PWGJE/Tasks/qgTreeCreator.cxx

+
+  void process(aod::ChargedMCDetectorLevelJets const& recoJets,
+               aod::ChargedMCParticleLevelJets const& truthJets,
+               aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets const& matches,


this table should be joined to ChargedMCDetectorLevelJets

nzardosh · 2026-03-30T08:36:25Z

PWGJE/Tasks/qgTreeCreator.cxx

+      float ptResp = -1;
+      int qg = -1;
+
+      for (auto const& match : matches) {


once it is joined you can access it differently

nzardosh · 2026-03-30T08:36:37Z

PWGJE/Tasks/qgTreeCreator.cxx

+      int qg = -1;
+
+      for (auto const& match : matches) {
+        if (match.chargedMCDetectorLevelJetId() != jet.globalIndex()) {


this also will change

nzardosh · 2026-03-30T08:36:50Z

PWGJE/Tasks/qgTreeCreator.cxx

+          continue;
+        }
+
+        auto truthJet = truthJets.iteratorAt(


Physicistdana · 2026-03-30T13:52:34Z

Hi @vkucera ,
Thank you. Sorry, I updated my name, and I will familiarize myself with the GitHub contribution guidelines and the framework, and update my code.

Physicistdana added 6 commits March 27, 2026 01:18

Update CMakeLists.txt

a750f5f

Update CMakeLists.txt

bf392dd

Create qgTreeCreator.cxx

d4b81eb

Delete PWGJE/qgTreeCreator.cxx

da5612f

Create qgTreeCreator.cxx

8cc4971

Merge branch 'AliceO2Group:master' into createqgTreeCreator

332def0

Physicistdana requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern, nzardosh and raymondEhlers as code owners March 28, 2026 04:38

github-actions bot added the pwgje label Mar 28, 2026

github-actions bot changed the title ~~Createqg tree creator~~ [PWGJE] Createqg tree creator Mar 28, 2026

Physicistdana marked this pull request as draft March 28, 2026 04:45

Physicistdana closed this Mar 28, 2026

Physicistdana reopened this Mar 28, 2026

Physicistdana added 5 commits March 28, 2026 00:50

Update qgTreeCreator.cxx

65d1d22

Update CMakeLists.txt

874b775

Update CMakeLists.txt

7f83f26

Merge branch 'AliceO2Group:master' into createqgTreeCreator

c9665a1

Merge branch 'AliceO2Group:master' into createqgTreeCreator

f23ad14

Physicistdana marked this pull request as ready for review March 28, 2026 21:01

Physicistdana added 6 commits March 28, 2026 17:02

Update CMakeLists.txt

9bbf97f

Update qgTreeCreator.cxx

6747b9b

Update qgTreeCreator.cxx

391e1c7

Update CMakeLists.txt

836aba4

Update CMakeLists.txt

9420cc2

Merge branch 'AliceO2Group:master' into createqgTreeCreator

9e50c17

Update o2-linter.yml

6f9c472

Physicistdana requested review from a team, ddobrigk, dsekihat, iarsene, jgrosseo and ktf as code owners March 28, 2026 23:01

github-actions bot added the infrastructure label Mar 28, 2026

Physicistdana added 5 commits March 28, 2026 19:04

Update qgTreeCreator.cxx

b6545de

Update o2-linter.yml

10f4842

Update qgTreeCreator.cxx

5226b16

Update CMakeLists.txt

040af13

Update qgTreeCreator.cxx

6d008b9

Physicistdana changed the title ~~[PWGJE] Createqg tree creator~~ [Infrastructure,PWGJE] Create qg tree creator Mar 28, 2026

Physicistdana changed the title ~~[Infrastructure,PWGJE] Create qg tree creator~~ [PWGJE] Create qg tree creator Mar 28, 2026

Physicistdana changed the title ~~[PWGJE] Create qg tree creator~~ [Infrastructure,PWGJE] Create qg tree creator Mar 28, 2026

Physicistdana changed the title ~~[Infrastructure,PWGJE] Create qg tree creator~~ [PWGJE,Infrastructure] Create qg tree creator Mar 28, 2026

Physicistdana added 4 commits March 28, 2026 19:42

Update qgTreeCreator.cxx

60aeffb

Update qgTreeCreator.cxx

c4ef955

Update qgTreeCreator.cxx

6db5360

Update qgTreeCreator.cxx

5ae5f73

vkucera reviewed Mar 29, 2026

View reviewed changes

Physicistdana added 2 commits March 28, 2026 22:37

Merge branch 'AliceO2Group:master' into createqgTreeCreator

c415b12

Update qgTreeCreator.cxx

47a8656

vkucera reviewed Mar 29, 2026

View reviewed changes

vkucera marked this pull request as draft March 29, 2026 13:30

nzardosh reviewed Mar 30, 2026

View reviewed changes

Conversation

Physicistdana commented Mar 28, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vkucera commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Physicistdana commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

vkucera commented Mar 29, 2026 •

edited

Loading

Physicistdana commented Mar 30, 2026 •

edited

Loading