fix: use common type for numeric check on binary subtraction#3003
Merged
HerrCai0907 merged 2 commits intoAssemblyScript:mainfrom Mar 28, 2026
Merged
Conversation
Non-compound `-` computes `commonType` for both operands; the validity check should use `commonType.isNumericValue`, not `leftType.isNumericValue`.
HerrCai0907
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For non-compound binary
-, the compiler computescommonTypefrom both operands. The numeric validity check incorrectly usedleftType.isNumericValueinstead ofcommonType.isNumericValue.Change
commonType.isNumericValueso the check matches the type used for implicit conversion andmakeSub.Contributor