Skip to content

E-Board vote v2#98

Merged
tallen42 merged 5 commits intodevfrom
eboard-vote-v2
Mar 28, 2026
Merged

E-Board vote v2#98
tallen42 merged 5 commits intodevfrom
eboard-vote-v2

Conversation

@tallen42
Copy link
Copy Markdown
Contributor

What

E-Board can run votes with the proper weight of their position (duals n stuff).

Why

E-Board should get to Vote(.csh.rit.edu) too!

Test Plan

Local vote. Made myself 1/2 of Imps temporarily :)

Env Vars

no

Checklist

  • Tested all changes locally

tallen42 and others added 4 commits March 27, 2026 00:09
This reverts commit fd575f9.
This reverts commit fd575f9

Signed-off-by: Tyler Allen <tyler@tallen.me>
@tallen42 tallen42 changed the base branch from main to dev March 28, 2026 03:03
Copy link
Copy Markdown
Contributor

@BigSpaceships BigSpaceships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny thing otherwise works great and looks good

main.go Outdated
Comment on lines +525 to +523
if !(slices.Contains(claims.UserInfo.Groups, "active_rtp") || slices.Contains(claims.UserInfo.Groups, "eboard")) {
if slices.Contains(claims.UserInfo.Groups, "active_rtp") || slices.Contains(claims.UserInfo.Groups, "eboard") {
} else {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is from you reverting it, but I think the way it was before is good

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh quite probably, I'll fix that thank you

@csh-sonarqube-community
Copy link
Copy Markdown

Failed Quality Gate failed

  • 3 New Issues (is greater than 0)
  • 0.00% Coverage on New Code (is less than 80.00%)

Project ID: ComputerScienceHouse_vote_c5ba863d-30d7-4fa9-97dd-4f2c58f8f5fa

View in SonarQube

Copy link
Copy Markdown
Contributor

@BigSpaceships BigSpaceships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tallen42 tallen42 merged commit ac72ac1 into dev Mar 28, 2026
2 of 3 checks passed
@tallen42 tallen42 deleted the eboard-vote-v2 branch March 28, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants