Support add/remove attachments when editing Olog entry#3754
Open
georgweiss wants to merge 5 commits intomasterfrom
Open
Support add/remove attachments when editing Olog entry#3754georgweiss wants to merge 5 commits intomasterfrom
georgweiss wants to merge 5 commits intomasterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE This PR requires commit 53a9ca03c8a50c0a89955f46976523a00891e106 or later from https://github.com/Olog/phoebus-olog. Not merged at the time of writing (2026-03-30).
This PR adds support for adding and removing attachments when editing an Olog entry. Note though that removing attachments only removes the references in the updated entry. Such attachments are not deleted from storage, they are still accessible when inspecting the log entry history.
Testing:
Documentation: