Conversation
bevanjkay
left a comment
There was a problem hiding this comment.
Please explain your changes when opening these kinds of PRs.
Substantial changes to tests should be described adequately.
Was there a significant refactor of the package that requires test refactoring?
Are we removing tests that uncovered genuine regressions?
Sorry, have missed this (also missed putting this in draft), as I fall asleep yesterday. I was just testing out how to make the test more robust but still show failures to indicate upstream changes. This means, testing lsp function might not be that stable since it might have too much false positive failes. Will, update it |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?fixes #274592