Skip to content

[🔥AUDIT🔥] Remove unused backwards compatibility feature for terraform action#112

Open
jwbron wants to merge 2 commits intomainfrom
rm-unused-compat
Open

[🔥AUDIT🔥] Remove unused backwards compatibility feature for terraform action#112
jwbron wants to merge 2 commits intomainfrom
rm-unused-compat

Conversation

@jwbron
Copy link
Copy Markdown
Contributor

@jwbron jwbron commented Sep 8, 2025

🖍 This is an audit! 🖍

Summary:

tf_vars_json wasn't ever actually used, so we don't need this backwards compatibility support.

Issue: INFRA-XXXX

Test plan:

Test it out in internal-services by updating the action ref to this branch.

@jwbron jwbron self-assigned this Sep 8, 2025
@jwbron jwbron requested a review from a team September 8, 2025 18:56
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: af7fd28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
generate-terraform-plan Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team September 8, 2025 18:56
@khan-actions-bot
Copy link
Copy Markdown
Contributor

khan-actions-bot commented Sep 8, 2025

Gerald

Required Reviewers
  • @Khan/github-actions for changes to .changeset/empty-hounds-push.md, actions/generate-terraform-plan/action.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Copy Markdown
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeresig jeresig removed the request for review from a team November 18, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants