Fix: Add JavaFX requirement check on startup#278
Open
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Open
Fix: Add JavaFX requirement check on startup#278mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
mgaffigan wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Collaborator
|
Hmm.. this would prompt some people to go "It says Java 17 required and Java 17 installed.. what am I doing wrong?" |
Contributor
Author
At some point, they do have to understand the difference between SE and FX, but I'm open to other phrasing. I also assume the message will be used for version issues in the future. |
|
As well as 'Detected Java runtime' could it have a second line addressing the other key factor? e..g. 'JFX..." Displaying JFX version could be confusing so maybe display a status such as 'Present' or 'Not Found'? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a startup check to verify the environment is acceptable to the app. Can't check for java version since we're targeting bytecode 61, but does check Java FX.
Here's the new startup error.
Tested using Azul Zulu JRE 17 FX and SE
Closes #277