Skip to content

fix(app): fix labware dobule-count#21139

Open
koji wants to merge 3 commits intoedgefrom
fix_AUTH-2819
Open

fix(app): fix labware dobule-count#21139
koji wants to merge 3 commits intoedgefrom
fix_AUTH-2819

Conversation

@koji
Copy link
Copy Markdown
Contributor

@koji koji commented Mar 28, 2026

Overview

add a set to avoid double-counting and export a jsx as a component.

Screenshot 2026-03-27 at 8 31 48 PM

close AUTH-2819

Test Plan and Hands on Testing

  • open Desktop app
  • import the protocol and custom labwares that are attached to the ticket
  • setup the protocol and click labware tab in protocol setup details

Changelog

  • update util function to avoid double-counting labware that is initially loaded
  • export LabwareDetailOverflowMenu

Review requests

Risk assessment

low

@koji koji requested a review from jerader March 28, 2026 00:32
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.46%. Comparing base (a0c5f8e) to head (4d9bf7d).
⚠️ Report is 24 commits behind head on edge.

Files with missing lines Patch % Lines
...otocolLabwareDetails/LabwareDetailOverflowMenu.tsx 64.44% 16 Missing ⚠️
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 40.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #21139      +/-   ##
==========================================
- Coverage   57.55%   57.46%   -0.10%     
==========================================
  Files        3912     3921       +9     
  Lines      320612   321700    +1088     
  Branches    46091    46197     +106     
==========================================
+ Hits       184540   184849     +309     
- Misses     135851   136628     +777     
- Partials      221      223       +2     
Flag Coverage Δ
app 45.14% <58.33%> (-0.06%) ⬇️
step-generation 5.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...p/ProtocolDetails/ProtocolLabwareDetails/index.tsx 91.01% <ø> (ø)
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 41.37% <40.00%> (-0.78%) ⬇️
...otocolLabwareDetails/LabwareDetailOverflowMenu.tsx 64.44% <64.44%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review March 28, 2026 00:38
@koji koji changed the title Fix auth 2819 fix(app): fix labware dobule-count Mar 28, 2026
@koji koji requested a review from ncdiehl11 March 28, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant