Resolve race conditions for loadPreferences#729
Open
SharonStrats wants to merge 8 commits intofix/pref-error-msgfrom
Open
Resolve race conditions for loadPreferences#729SharonStrats wants to merge 8 commits intofix/pref-error-msgfrom
SharonStrats wants to merge 8 commits intofix/pref-error-msgfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses race conditions caused by repeated callers triggering preferences/roles loading during a login session, by deduping in-flight work and caching results so settings resources are initialized once and reused.
Changes:
- Add in-flight dedupe + caching for
ensureLoadedPreferencesandgetUserRoleskeyed by WebID. - After
authSessionlogin, eagerly initialize preferences and refresh key authenticated resources to avoid transient 404s. - Bump package version to
3.0.6.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/login/login.ts |
Adds promise dedupe/caching for preference loading + roles lookup; refreshes storage/settings resources after login to reduce race-related 404s. |
package.json |
Version bump to reflect the behavioral change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #464
The work creating on PR SolidOS/solid-logic#238 creating the settings files to be like the server creates them brought to light some issues with GetUserRoles being called multiple times during the login session causing race conditions to happen with the file creation that could potentially happen in loadPreferences if the settings files for a user do not exist.
Also there was a problem with the settings folder appearing after creation. It either did not appear or gave a 404 error when shown. This is fixed in this PR.