Conversation
|
@anirudhkrishnan2718 this should work I think. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Once these changes are merged, can I install the current version of the repository or do I need to wait for an official release? |
|
You can pip install directly any branch from git from pip -- or clone it and do a |
pyproject.toml
Outdated
|
|
||
| [tool.basedpyright] | ||
| exclude = ["**/*.ipynb"] | ||
| stubPath = "" |
There was a problem hiding this comment.
Don't think this is necessary: first tried generating stubs with pyright but that did not work.
gepcel
left a comment
There was a problem hiding this comment.
I don't know much about the mechanisms of Pyright and Mypy, but this seems like a very smart and clever way to handle it.
|
Me neither. This is what I gathered from stackoverflow. Normally these packages would just import things or provide a .pyi file but we can't do that as it is hidden behind when code is actually used and imported. |
This is a bit uncharted territory for me, but I believe the typing block can be used to ensure that we still have quick load time but type hinting can look at the definition of our module and functions.
New public api would need to be explicitly added here to ensure that it does not break inspection.
Closes #655