Merged
Conversation
…relax the helper regression to assert the stable post-reflow behavior, and document that broad pytest verification should run with -n 4 so future validation stays fast on top of main.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #666
The first was the intended indexing change. SubplotGrid.getitem used to unwrap a single-item 2D slice and return the axis itself. After the fix, a slice always returns a SubplotGrid, even when it contains one axis. That changed object identity in a few tests, so the gridspec, legend, and subplots expectations had to be updated. That part was the regression you originally pointed out, and it is now already on main.
The second issue was not caused by indexing. When I widened the test run, a geo-sharing failure showed up because cartopy cyl was being misclassified as non-rectilinear in ultraplot/axes/geo.py. In this environment, cartopy reports several projections with name == "unknown", so the old string-based check missed PlateCarree/cyl. That made the shared ticklabel logic treat a rectilinear geo axis like a curved one and skip sharing behavior. The fix was to classify known rectilinear cartopy projections by class instead of relying on proj.name, and then update the projection-sharing tests in ultraplot/tests/test_projections.py.
While validating the rebased branch, I also found a separate baseline failure in the inset colorbar helper test. That one came from invalid non-finite artist extents being included in the reflow check in ultraplot/axes/base.py, plus a brittle pre-reflow assertion in ultraplot/tests/test_axes_base_colorbar_helpers.py. I fixed both because you wanted the full suite green.