✨ Add functionality for managing user favorite activities by Beelzenef · Pull Request #45 · WikkaLab/TaleEngine

Beelzenef · 2026-03-30T11:33:16Z

Add or remove activities from favorites per user

Copilot

Pull request overview

Adds API + service/repository support to let users manage and fetch their favourite activities.

Changes:

Add endpoints to list favourites (filtered + by user/edition) and to add/remove a favourite.
Add CQRS query/command methods and service logic to read/update favourite relationships.
Update repository method to optionally filter “include favourites” queries by editionId.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
TaleEngine/TaleEngine/Controllers/V1/ActivityController.cs	Adds/updates endpoints for fetching and mutating favourite activities.
TaleEngine/TaleEngine.Testing/Controllers/V1/ActivityControllerTests.cs	Adds controller tests for favourites list/add/remove.
TaleEngine/TaleEngine.Data/Repositories/ActivityRepository.cs	Updates `GetAllIncludeFavs` to accept `editionId` and filter optionally.
TaleEngine/TaleEngine.Data.Contracts/Repositories/IActivityRepository.cs	Updates repository contract parameter to `editionId`.
TaleEngine/TaleEngine.Bussiness/Queries/ActivityQueries.cs	Adds `FavouriteActivitiesByUserQuery`.
TaleEngine/TaleEngine.Bussiness/Contracts/IActivityQueries.cs	Exposes `FavouriteActivitiesByUserQuery` in the queries interface.
TaleEngine/TaleEngine.Bussiness/Contracts/IActivityCommands.cs	Exposes add/remove favourite commands.
TaleEngine/TaleEngine.Bussiness/Commands/ActivityCommands.cs	Implements add/remove favourite commands via `IActivityService`.
TaleEngine/TaleEngine.Application/ActivityService.cs	Implements favourite list/add/remove logic and updates favourite filtering predicate.
TaleEngine/TaleEngine.Application.Contracts/IActivityService.cs	Exposes favourite list/add/remove methods in the service contract.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T11:37:47Z

TaleEngine/TaleEngine/Controllers/V1/ActivityController.cs

+        [HttpPut("[action]/{userId}")]
+        public IActionResult GetFavouriteActivitiesFiltered(int userId, [FromBody] ActivityFilterRequest activityFilterRequest)
        {
-            int userId = 1;
-
            var result = _queries.ActiveActivitiesFilteredQuery(activityFilterRequest, userId);

-            if (result == null)
+            if (result == null || result.Activities == null || result.Activities.Count == 0)
+            {
+                return NoContent();
+            }
+
+            return Ok(result);
+        }


There are no controller tests covering the updated GetFavouriteActivitiesFiltered behavior (route now requires userId and the method returns 204 on empty Activities). Adding tests for the 200 and 204 paths would help prevent regressions, especially since this endpoint has different empty-result handling than GetActivitiesFiltered.

Copilot · 2026-03-30T11:37:47Z

TaleEngine/TaleEngine.Testing/Controllers/V1/ActivityControllerTests.cs

+        }
+
+        [Fact]
+        public void AddFavouriteActivity_Fail_Success()


Test name AddFavouriteActivity_Fail_Success is contradictory (it’s a failure-path test expecting 400). Renaming it to reflect the behavior under test (e.g., AddFavouriteActivity_Failure_ReturnsBadRequest) will make the test suite easier to scan and maintain.

Suggested change

public void AddFavouriteActivity_Fail_Success()

public void AddFavouriteActivity_Failure_ReturnsBadRequest()

Copilot · 2026-03-30T11:37:48Z

TaleEngine/TaleEngine.Testing/Controllers/V1/ActivityControllerTests.cs

+        }
+
+        [Fact]
+        public void RemoveFavouriteActivity_Fail_Success()


Test name RemoveFavouriteActivity_Fail_Success is contradictory (it’s a failure-path test expecting 400). Consider renaming it to something like RemoveFavouriteActivity_Failure_ReturnsBadRequest for clarity.

Suggested change

public void RemoveFavouriteActivity_Fail_Success()

public void RemoveFavouriteActivity_Failure_ReturnsBadRequest()

Copilot · 2026-03-30T11:37:48Z

TaleEngine/TaleEngine/Controllers/V1/ActivityController.cs

+            if (result == null || result.Activities == null || result.Activities.Count == 0)
+            {
+                return NoContent();
+            }
+
+            return Ok(result);


GetFavouriteActivitiesFiltered returns 204 when result.Activities is empty, but GetActivitiesFiltered returns 200 with an ActivityFilteredResult payload even when the list is empty. Since ActivityFilteredResult includes paging metadata (CurrentPage/TotalPages), returning 204 here drops that information and makes the two filtered endpoints inconsistent. Consider always returning Ok(result) when result != null and letting Activities be empty, or align both endpoints to the same behavior.

Copilot · 2026-03-30T11:37:48Z

TaleEngine/TaleEngine.Application/ActivityService.cs

+                activity = _unitOfWork.ActivityRepository.GetAllIncludeFavs(activity.EditionId)
+                    .FirstOrDefault(a => a.Id == activityId);
+
+                if (activity == null)
+                {
+                    return false;
+                }
+


AddFavouriteActivity loads the full list of activities (with UsersFav included) for the edition via GetAllIncludeFavs(...) and then filters in-memory with FirstOrDefault. This can become expensive as activities/users grow and is unnecessary when you only need a single activity. Prefer a repository method that fetches a single activity by id with UsersFav included (or change GetAllIncludeFavs to return an IQueryable so the filter runs in SQL).

Suggested change

activity = _unitOfWork.ActivityRepository.GetAllIncludeFavs(activity.EditionId)

.FirstOrDefault(a => a.Id == activityId);

if (activity == null)

{

return false;

}

Copilot · 2026-03-30T11:37:48Z

TaleEngine/TaleEngine.Application/ActivityService.cs

+                activity = _unitOfWork.ActivityRepository.GetAllIncludeFavs(activity.EditionId)
+                    .FirstOrDefault(a => a.Id == activityId);
+
+                if (activity?.UsersFav == null)


RemoveFavouriteActivity calls GetAllIncludeFavs(activity.EditionId) (materializing all activities in the edition with favorites) and then filters by id in-memory. This is potentially very costly and can be replaced by a query that fetches just the targeted activity with UsersFav included.

Suggested change

activity = _unitOfWork.ActivityRepository.GetAllIncludeFavs(activity.EditionId)

.FirstOrDefault(a => a.Id == activityId);

if (activity?.UsersFav == null)

if (activity.UsersFav == null)

Copilot · 2026-03-30T11:37:49Z

TaleEngine/TaleEngine.Application/ActivityService.cs

+                .Where(a => a.EditionId == editionId
+                    && a.StatusId == activeStatus.Id


GetFavActivitiesFiltered starts from GetAllIncludeFavs(editionId), which already applies an edition filter when editionId is non-default, and then immediately filters a.EditionId == editionId again. This redundancy makes the intent harder to read and risks diverging if repository filtering logic changes. Consider removing the duplicate edition predicate (or, more broadly, pushing the whole filter down into the repository so it runs in the database).

Suggested change

.Where(a => a.EditionId == editionId

&& a.StatusId == activeStatus.Id

.Where(a => a.StatusId == activeStatus.Id

✨ Add functionality for managing user favorite activities

f43005a

Beelzenef requested a review from Copilot March 30, 2026 11:33

Beelzenef self-assigned this Mar 30, 2026

Beelzenef added the enhancement New feature or request label Mar 30, 2026

Copilot started reviewing on behalf of Beelzenef March 30, 2026 11:33 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add functionality for managing user favorite activities#45

✨ Add functionality for managing user favorite activities#45
Beelzenef wants to merge 1 commit intomainfrom
feat/fav-activities

Beelzenef commented Mar 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	public void AddFavouriteActivity_Fail_Success()
	public void AddFavouriteActivity_Failure_ReturnsBadRequest()

	public void RemoveFavouriteActivity_Fail_Success()
	public void RemoveFavouriteActivity_Failure_ReturnsBadRequest()

		.Where(a => a.EditionId == editionId
		&& a.StatusId == activeStatus.Id

	.Where(a => a.EditionId == editionId
	&& a.StatusId == activeStatus.Id
	.Where(a => a.StatusId == activeStatus.Id

Conversation

Beelzenef commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Beelzenef commented Mar 30, 2026 •

edited

Loading