Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Move handling
-J helpinto the options parser instead of performing it later. This means we can inlineJsGroupOptionwhereverJsGroupValuewas used since we're not propagating that help was requested. Also update the error message emitted when someone tries to use-Jwith a plugin to mention it's not supported when specifying a plugin.Why am I making this change?
Fixes #1157.
I opted to move the handling with
-J helpinto the parser because it seems like makinginputoptional in this one particular case would introduce more complexity compared to just loading the default plugin to provide the runtime options. I updated the error message for using-Jwith plugins because it could be confusing for a user if the-J helpmessage says a particular option is supported and then they get an error message saying that option is not supported when trying to use it with a plugin.Checklist
javy-plugin-apiif the QuickJS bytecode has changed.javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.