Skip to content

Handle additional error-like objects#245

Open
rholstad wants to merge 6 commits intochaijs:mainfrom
rholstad:master
Open

Handle additional error-like objects#245
rholstad wants to merge 6 commits intochaijs:mainfrom
rholstad:master

Conversation

@rholstad
Copy link
Copy Markdown

Checks that checkError.getConstructorName(reason) returns a String. If reason is neither an Error object nor a function, try calling checkError.getMessage(reason). If reason is error-like, it may have a message that is more useful than the description of reason.

@domenic
Copy link
Copy Markdown
Collaborator

domenic commented Apr 30, 2018

Is this how Chai's built-in error testing behaves?

If so, we'll need to also update the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants