Replace more equality checks with identity checks#195
Open
aaronj0 wants to merge 1 commit intocompiler-research:masterfrom
Open
Replace more equality checks with identity checks#195aaronj0 wants to merge 1 commit intocompiler-research:masterfrom
aaronj0 wants to merge 1 commit intocompiler-research:masterfrom
Conversation
vgvassilev
reviewed
Mar 27, 2026
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Can you add the motivation of that change in the commit log?
From root-project/root@d5bbb36 Enforces more strict comparison operator implementation in cppyy. Python falls back to using "is" when the equality operator is not implemented. This is to ensure that we don't use some hacks in cppyy where if there is no C++ side equality operator then we check if the types match, if the pointers match and this is not optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.