feat: add Game Center entry points to desktop and mobile sidebars#5812
Open
AmarTrebinjac wants to merge 2 commits intomainfrom
Open
feat: add Game Center entry points to desktop and mobile sidebars#5812AmarTrebinjac wants to merge 2 commits intomainfrom
AmarTrebinjac wants to merge 2 commits intomainfrom
Conversation
Add navigation entries for the /game-center page, gated behind the quests feature flag. Desktop sidebar shows it below Agentic Hub, mobile profile menu shows it in the Misc section. Includes a new Joystick icon with outlined and filled variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@claude fix the build errors |
Contributor
|
Claude finished @AmarTrebinjac's task in 13m 18s —— View job Fixed Build ErrorsAll 5 TypeScript strict mode violations were pre-existing issues in files that got triggered for the first time because this PR modified them. Root cause: Fixes applied in commit
|
… and MainSection - ProfileSettingsMenu: convert null title to undefined for ProfileSection prop - ProfileSettingsMenu: provide no-op fallback for optional onClose in drawer props - ProfileSettingsMenu: widen return type of ProfileSettingsMenuDesktop to ReactElement | null - MainSection: use type predicate in filter for SidebarMenuItem[] narrowing - MainSection: use non-null assertion for user inside isLoggedIn branch Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
questsFeature+ logged-in userJoystickIconwith outlined and filled SVG variants following the standard icon patternKey decisions
JoystickIconsince no game-related icon existed in the icon libraryisForcedLink: trueandrequiresLogin: true(same pattern as Agentic Hub)isQuestsFeatureEnabled(same pattern as existinggamificationitem)questsFeature(quests)Test plan
/game-center, icon toggles filled/outlined on activeCloses ENG-1164
Created by Huginn 🐦⬛
Preview domain
https://eng-1164-game-center-entry-point.preview.app.daily.dev