Add bundle telemetry for variables, validation gap, and deploy graph#4852
Draft
shreyas-goenka wants to merge 7 commits intomainfrom
Draft
Add bundle telemetry for variables, validation gap, and deploy graph#4852shreyas-goenka wants to merge 7 commits intomainfrom
shreyas-goenka wants to merge 7 commits intomainfrom
Conversation
…ownload Co-authored-by: Isaac
The codegen tool (`go run .`) now automatically downloads the SHA256SUMS file from the GitHub release and embeds the checksums into the generated root.go. When bumping the provider version, developers only need to update version.go — checksums are resolved automatically. Co-authored-by: Isaac
These tests download large archives from the internet. Gate them behind `testing.Short()` so they're skipped during normal CI (`make test`) and only run in nightly/long test sessions. Co-authored-by: Isaac
…check Instead of a separate test that downloads large archives on every test run, verify the checksum inline during codegen: FetchProviderChecksums now downloads the linux_amd64 zip and verifies it matches the parsed SHA256SUMS entry. This runs once during `go run .` (provider version bump) rather than on every `make test`. Co-authored-by: Isaac
Co-authored-by: Isaac
…egen Co-authored-by: Isaac
Collaborator
|
Commit: 3c456c1
21 interesting tests: 10 SKIP, 6 RECOVERED, 5 flaky
Top 50 slowest tests (at least 2 minutes):
|
…pendency graph
Add several new telemetry signals to improve understanding of DABs usage patterns:
- Detect nested variable references (var-in-var patterns like ${var.foo_${var.bar}})
- Track variable defaults count, lookup type distribution, override sources (env var, file, CLI flag), and resolution depth
- Track validation-pass-deploy-fail gap via "validation_passed" metric with deferred telemetry logging
- Track direct engine deployment plan metrics: action types, resource counts, dependency graph depth/width
- Remove unused telemetry fields: SetFields, TerraformStateSizeBytes, FromWebTerminal
Co-authored-by: Isaac
3f7199b to
3c456c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${var.foo_${var.bar}}) to understand how common var-in-var patterns arevalidation_passedbool metric + deferred telemetry logging so deploy failures are always capturedSetFields,TerraformStateSizeBytes,FromWebTerminalTest plan
validation_passedmetricgo build ./...passesmake lintcleanThis pull request was AI-assisted by Isaac.