Add "did you mean?" suggestions for variable reference typos#4864
Draft
shreyas-goenka wants to merge 1 commit intomainfrom
Draft
Add "did you mean?" suggestions for variable reference typos#4864shreyas-goenka wants to merge 1 commit intomainfrom
shreyas-goenka wants to merge 1 commit intomainfrom
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
When a ${...} variable reference fails to resolve, the error now suggests
the closest valid path using Levenshtein distance. The algorithm walks
the entire path greedily, correcting multiple segments in one suggestion.
Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
did-you-mean
branch
from
ef939ce to
d25423f
Compare
Collaborator
|
Commit: d25423f
27 interesting tests: 10 SKIP, 7 KNOWN, 7 flaky, 3 FAIL
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${...}variable reference fails to resolve, suggest the closest valid path using Levenshtein distance${bundl.nme}→${bundle.name})idnot in config tree)var.X↔variables.X.valueshorthand rewriting in suggestionsvar,bundle,workspaceprefixes): appends "Did you mean?" to the errorresourcestypos, prefix typos): emits a warning to avoid breaking existing behaviorTest plan
bundle/variables/did-you-mean(both terraform and direct engines)make test)This pull request was AI-assisted by Isaac.