Skip to content

Migrate manual files to logging abstraction#742

Draft
mihaimitrea-db wants to merge 3 commits intomainfrom
mihaimitrea-db/stack/logging-migration
Draft

Migrate manual files to logging abstraction#742
mihaimitrea-db wants to merge 3 commits intomainfrom
mihaimitrea-db/stack/logging-migration

Conversation

@mihaimitrea-db
Copy link
Copy Markdown
Contributor

@mihaimitrea-db mihaimitrea-db commented Mar 26, 2026

🥞 Stacked PR

Use this link to review incremental changes.


Summary

Migrates all manually-maintained source files from direct org.slf4j imports to the SDK's logging abstraction (com.databricks.sdk.core.logging). After this PR, no hand-written file in the SDK references
SLF4J directly — all logging goes through the abstraction introduced in PR #740.

Why

PRs #740 and #741 introduced the logging abstraction and the JUL backend, but every existing call site still imported org.slf4j.Logger and org.slf4j.LoggerFactory directly. Until those imports are
rewritten, users cannot actually swap the logging backend — the abstraction would be dead code.

This PR completes the migration for all manually-maintained files. Auto-generated files are left unchanged and will be addressed separately via codegen updates.

What changed

Interface changes

None.

Behavioral changes

None. All logging calls pass through the abstraction layer, which defaults to SLF4J. Existing users see no difference.

Internal changes

  • 25 files updated: each file's org.slf4j.Logger / org.slf4j.LoggerFactory imports are replaced with com.databricks.sdk.core.logging.Logger / com.databricks.sdk.core.logging.LoggerFactory. No
    other code changes — the Logger API is identical.
  • Files span core, core.oauth, core.retry, core.utils, core.error, core.commons, and mixin packages.

How is this tested?

  • This is a purely mechanical import swap; the Logger abstraction exposes the same debug/info/warn/error methods as org.slf4j.Logger.
  • Full test suite (1140 tests) passes.

@mihaimitrea-db mihaimitrea-db self-assigned this Mar 26, 2026
@mihaimitrea-db mihaimitrea-db force-pushed the mihaimitrea-db/stack/logging-migration branch 2 times, most recently from e07eca3 to b52d9a0 Compare March 30, 2026 08:16
@mihaimitrea-db mihaimitrea-db force-pushed the mihaimitrea-db/stack/logging-migration branch from b52d9a0 to 429b118 Compare March 30, 2026 08:33
@mihaimitrea-db
Copy link
Copy Markdown
Contributor Author

Range-diff: stack/logging-jul (b52d9a0 -> 429b118)
NEXT_CHANGELOG.md
@@ -0,0 +1,10 @@
+diff --git a/NEXT_CHANGELOG.md b/NEXT_CHANGELOG.md
+--- a/NEXT_CHANGELOG.md
++++ b/NEXT_CHANGELOG.md
+ ### Internal Changes
+ * Introduced a logging abstraction (`com.databricks.sdk.core.logging`) that decouples the SDK from SLF4J. Users can now provide their own logging backend by extending `LoggerFactory` and calling `LoggerFactory.setDefault()` before creating any SDK client. SLF4J remains the default.
+ * Added `java.util.logging` as a supported alternative logging backend. Activate it with `LoggerFactory.setDefault(JulLoggerFactory.INSTANCE)`.
++* Migrated internal SDK classes from direct `org.slf4j` imports to the new logging abstraction.
+ 
+ ### API Changes
+ * Add `createCatalog()`, `createSyncedTable()`, `deleteCatalog()`, `deleteSyncedTable()`, `getCatalog()` and `getSyncedTable()` methods for `workspaceClient.postgres()` service.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java
+ import com.databricks.sdk.core.http.Request;
+ import com.databricks.sdk.core.http.RequestOptions;
+ import com.databricks.sdk.core.http.Response;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.retry.NoRetryStrategyPicker;
+ import com.databricks.sdk.core.retry.RequestBasedRetryStrategyPicker;
+ import com.databricks.sdk.core.retry.RetryStrategy;
  import java.time.format.DateTimeFormatter;
  import java.util.*;
  import java.util.function.Function;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Simplified REST API client with retries, JSON POJO SerDe through Jackson and exception POJO
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.oauth.CachedTokenSource;
+ import com.databricks.sdk.core.oauth.OAuthHeaderFactory;
+ import com.databricks.sdk.core.oauth.Token;
  import com.databricks.sdk.support.InternalApi;
  import com.fasterxml.jackson.databind.ObjectMapper;
  import java.util.*;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class AzureCliCredentialsProvider implements CredentialsProvider {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.oauth.Token;
+ import com.databricks.sdk.core.oauth.TokenSource;
+ import com.databricks.sdk.core.utils.Environment;
  import java.util.Arrays;
  import java.util.List;
  import org.apache.commons.io.IOUtils;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class CliTokenSource implements TokenSource {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/ConfigLoader.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ConfigLoader.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ConfigLoader.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ConfigLoader.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/ConfigLoader.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.utils.Environment;
+ import com.databricks.sdk.support.InternalApi;
+ import java.io.FileNotFoundException;
  import org.apache.commons.configuration2.INIConfiguration;
  import org.apache.commons.configuration2.SubnodeConfiguration;
  import org.apache.commons.configuration2.ex.ConfigurationException;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class ConfigLoader {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksCliCredentialsProvider.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksCliCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksCliCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksCliCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksCliCredentialsProvider.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.oauth.CachedTokenSource;
+ import com.databricks.sdk.core.oauth.OAuthHeaderFactory;
+ import com.databricks.sdk.core.oauth.Token;
  import com.fasterxml.jackson.databind.ObjectMapper;
  import java.nio.charset.StandardCharsets;
  import java.util.*;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class DatabricksCliCredentialsProvider implements CredentialsProvider {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DatabricksConfig.java
+ import com.databricks.sdk.core.http.HttpClient;
+ import com.databricks.sdk.core.http.Request;
+ import com.databricks.sdk.core.http.Response;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.oauth.ErrorTokenSource;
+ import com.databricks.sdk.core.oauth.HostMetadata;
+ import com.databricks.sdk.core.oauth.OAuthHeaderFactory;
  import java.time.Duration;
  import java.util.*;
  import org.apache.http.HttpMessage;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  public class DatabricksConfig {
    private static final Logger LOG = LoggerFactory.getLogger(DatabricksConfig.class);
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
@@ -1,13 +1,17 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.oauth.*;
+ import com.databricks.sdk.support.InternalApi;
  import com.google.common.base.Strings;
  import java.util.ArrayList;
  import java.util.List;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * The DefaultCredentialsProvider is the primary authentication handler for the Databricks SDK. It
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleCredentialsCredentialsProvider.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleCredentialsCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleCredentialsCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleCredentialsCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleCredentialsCredentialsProvider.java
+ import static com.databricks.sdk.core.utils.GoogleUtils.GCP_SCOPES;
+ import static com.databricks.sdk.core.utils.GoogleUtils.SA_ACCESS_TOKEN_HEADER;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import com.google.auth.oauth2.*;
+ import com.google.auth.oauth2.IdTokenProvider.Option;
  import java.nio.file.Files;
  import java.nio.file.Paths;
  import java.util.*;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class GoogleCredentialsCredentialsProvider implements CredentialsProvider {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleIdCredentialsProvider.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleIdCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleIdCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleIdCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/GoogleIdCredentialsProvider.java
+ import static com.databricks.sdk.core.utils.GoogleUtils.GCP_SCOPES;
+ import static com.databricks.sdk.core.utils.GoogleUtils.SA_ACCESS_TOKEN_HEADER;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import com.google.auth.oauth2.GoogleCredentials;
+ import com.google.auth.oauth2.IdTokenCredentials;
  import com.google.auth.oauth2.ImpersonatedCredentials;
  import java.io.IOException;
  import java.util.*;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class GoogleIdCredentialsProvider implements CredentialsProvider {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/NotebookNativeCredentialsProvider.java
@@ -1,13 +1,16 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/NotebookNativeCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/NotebookNativeCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/NotebookNativeCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/NotebookNativeCredentialsProvider.java
+ package com.databricks.sdk.core;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
  import java.lang.reflect.Field;
  import java.lang.reflect.InvocationTargetException;
  import java.util.*;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * A CredentialsProvider that uses the API token from the command context to authenticate.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java
+ import com.databricks.sdk.core.http.HttpClient;
+ import com.databricks.sdk.core.http.Request;
+ import com.databricks.sdk.core.http.Response;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.utils.CustomCloseInputStream;
+ import com.databricks.sdk.core.utils.ProxyUtils;
+ import com.databricks.sdk.support.InternalApi;
  import org.apache.http.impl.conn.PoolingHttpClientConnectionManager;
  import org.apache.http.protocol.BasicHttpContext;
  import org.apache.http.protocol.HttpContext;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  public class CommonsHttpClient implements HttpClient {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/AbstractErrorMapper.java
@@ -1,13 +1,16 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/AbstractErrorMapper.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/AbstractErrorMapper.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/AbstractErrorMapper.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/AbstractErrorMapper.java
+ import com.databricks.sdk.core.DatabricksError;
+ import com.databricks.sdk.core.error.details.ErrorDetails;
+ import com.databricks.sdk.core.http.Response;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
  import com.databricks.sdk.support.InternalApi;
  import java.util.HashMap;
  import java.util.Map;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  @InternalApi
  abstract class AbstractErrorMapper {
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureServicePrincipalCredentialsProvider.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureServicePrincipalCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureServicePrincipalCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureServicePrincipalCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/AzureServicePrincipalCredentialsProvider.java
+ package com.databricks.sdk.core.oauth;
+ 
+ import com.databricks.sdk.core.*;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.utils.AzureUtils;
+ import com.databricks.sdk.support.InternalApi;
  import com.fasterxml.jackson.databind.ObjectMapper;
  import java.util.HashMap;
  import java.util.Map;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Adds refreshed Azure Active Directory (AAD) Service Principal OAuth tokens to every request,
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/CachedTokenSource.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/CachedTokenSource.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/CachedTokenSource.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/CachedTokenSource.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/CachedTokenSource.java
+ package com.databricks.sdk.core.oauth;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.utils.ClockSupplier;
+ import com.databricks.sdk.core.utils.UtcClockSupplier;
+ import java.time.Duration;
  import java.time.Instant;
  import java.util.Objects;
  import java.util.concurrent.CompletableFuture;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * An OAuth TokenSource which can be refreshed.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Consent.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Consent.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Consent.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Consent.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Consent.java
+ import com.databricks.sdk.core.DatabricksException;
+ import com.databricks.sdk.core.commons.CommonsHttpClient;
+ import com.databricks.sdk.core.http.HttpClient;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.sun.net.httpserver.Headers;
+ import com.sun.net.httpserver.HttpExchange;
+ import com.sun.net.httpserver.HttpHandler;
  import java.util.Objects;
  import java.util.Optional;
  import org.apache.commons.io.IOUtils;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Consent provides a mechanism to retrieve an authorization code and exchange it for an OAuth token
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/DatabricksOAuthTokenSource.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/DatabricksOAuthTokenSource.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/DatabricksOAuthTokenSource.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/DatabricksOAuthTokenSource.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/DatabricksOAuthTokenSource.java
+ 
+ import com.databricks.sdk.core.DatabricksException;
+ import com.databricks.sdk.core.http.HttpClient;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.google.common.base.Strings;
+ import java.time.Instant;
+ import java.util.Arrays;
  import java.util.List;
  import java.util.Map;
  import java.util.Objects;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Implementation of TokenSource that handles OAuth token exchange for Databricks authentication.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EndpointTokenSource.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EndpointTokenSource.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EndpointTokenSource.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EndpointTokenSource.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/EndpointTokenSource.java
+ 
+ import com.databricks.sdk.core.DatabricksException;
+ import com.databricks.sdk.core.http.HttpClient;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import java.time.Instant;
  import java.util.HashMap;
  import java.util.Map;
  import java.util.Objects;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Represents a token source that exchanges a control plane token for an endpoint-specific dataplane
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProvider.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProvider.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProvider.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProvider.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/ExternalBrowserCredentialsProvider.java
+ import com.databricks.sdk.core.CredentialsProvider;
+ import com.databricks.sdk.core.DatabricksConfig;
+ import com.databricks.sdk.core.DatabricksException;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import java.io.IOException;
+ import java.nio.file.Path;
  import java.util.Objects;
  import java.util.Optional;
  import java.util.Set;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * A {@code CredentialsProvider} which implements the Authorization Code + PKCE flow by opening a
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileTokenCache.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileTokenCache.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileTokenCache.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileTokenCache.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/FileTokenCache.java
+ package com.databricks.sdk.core.oauth;
+ 
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.core.utils.SerDeUtils;
+ import com.databricks.sdk.support.InternalApi;
+ import com.fasterxml.jackson.databind.ObjectMapper;
  import java.nio.file.Files;
  import java.nio.file.Path;
  import java.util.Objects;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /** A TokenCache implementation that stores tokens as plain files. */
  @InternalApi
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentials.java
@@ -1,13 +1,16 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentials.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentials.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentials.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentials.java
+ import com.databricks.sdk.core.CredentialsProvider;
+ import com.databricks.sdk.core.DatabricksConfig;
+ import com.databricks.sdk.core.http.HttpClient;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
  import com.databricks.sdk.support.InternalApi;
  import java.io.Serializable;
  import java.util.Optional;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * An implementation of RefreshableTokenSource implementing the refresh_token OAuth grant type.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentialsTokenSource.java
@@ -1,13 +1,17 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentialsTokenSource.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentialsTokenSource.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentialsTokenSource.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/SessionCredentialsTokenSource.java
+ 
+ import com.databricks.sdk.core.DatabricksException;
+ import com.databricks.sdk.core.http.HttpClient;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
  import java.util.HashMap;
  import java.util.Map;
  import java.util.Optional;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * TokenSource that handles OAuth token refresh for SessionCredentials.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/TokenEndpointClient.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/TokenEndpointClient.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/TokenEndpointClient.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/TokenEndpointClient.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/TokenEndpointClient.java
+ import com.databricks.sdk.core.http.HttpClient;
+ import com.databricks.sdk.core.http.Request;
+ import com.databricks.sdk.core.http.Response;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import com.fasterxml.jackson.databind.ObjectMapper;
+ import java.io.IOException;
  import java.util.Map;
  import java.util.Objects;
  import org.apache.http.HttpHeaders;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * Client for interacting with an OAuth token endpoint.
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/retry/NonIdempotentRequestRetryStrategy.java
@@ -1,13 +1,18 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/retry/NonIdempotentRequestRetryStrategy.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/retry/NonIdempotentRequestRetryStrategy.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/retry/NonIdempotentRequestRetryStrategy.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/retry/NonIdempotentRequestRetryStrategy.java
+ package com.databricks.sdk.core.retry;
+ 
+ import com.databricks.sdk.core.DatabricksError;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import java.net.*;
+ import java.util.Arrays;
  import java.util.HashSet;
  import java.util.List;
  import java.util.Set;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * This class is used to determine if a non-idempotent request should be retried. We essentially
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/core/utils/OSUtils.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/utils/OSUtils.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/utils/OSUtils.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/core/utils/OSUtils.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/core/utils/OSUtils.java
+ package com.databricks.sdk.core.utils;
+ 
+ import com.databricks.sdk.core.DatabricksException;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.support.InternalApi;
+ import java.io.IOException;
+ import java.nio.file.Files;
  import java.nio.file.Path;
  import java.nio.file.Paths;
  import java.util.List;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  /**
   * OSUtils is an interface that provides utility methods for determining the current operating
\ No newline at end of file
databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/ClustersExt.java
@@ -1,13 +1,19 @@
 diff --git a/databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/ClustersExt.java b/databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/ClustersExt.java
 --- a/databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/ClustersExt.java
 +++ b/databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/ClustersExt.java
+ 
+ import com.databricks.sdk.core.ApiClient;
+ import com.databricks.sdk.core.DatabricksError;
++import com.databricks.sdk.core.logging.Logger;
++import com.databricks.sdk.core.logging.LoggerFactory;
+ import com.databricks.sdk.service.compute.*;
+ import java.time.Duration;
+ import java.util.ArrayList;
  import java.util.concurrent.TimeoutException;
  import java.util.function.Function;
  import java.util.stream.Collectors;
 -import org.slf4j.Logger;
 -import org.slf4j.LoggerFactory;
-+import com.databricks.sdk.core.logging.Logger;
-+import com.databricks.sdk.core.logging.LoggerFactory;
  
  public class ClustersExt extends ClustersAPI {
    private static final Logger LOG = LoggerFactory.getLogger(ClustersExt.class);
\ No newline at end of file

Reproduce locally: git range-diff 80ecee4..b52d9a0 02b6cb5..429b118 | Disable: git config gitstack.push-range-diff false

@github-actions
Copy link
Copy Markdown

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-java

Inputs:

  • PR number: 742
  • Commit SHA: 429b1183fab5f48f4bc1ee38a7007aa82d5fe5dd

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant