Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class “model selection” support to the Copilot Engine SDK, allowing engines (and the local test CLI) to consume platform-selected model metadata and resolve an effective model to use.
Changes:
- Extend
JobDetailswith model selection fields (features.model_selection,selected_model,default_model,available_models, etc.). - Add SDK helpers
isModelSelectionEnabledandresolveSelectedModeland export them from the package entrypoint. - Update the integration guide and
engine-climock platform/runner to surface model selection fields and environment variables.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/index.ts |
Exposes model selection helpers/types from the SDK public API. |
src/client.ts |
Adds job fields plus helper APIs to detect/resolve selected models. |
docs/integration-guide.md |
Documents new job fields/env vars and shows SDK usage. |
cli/internal/server/server.go |
Mock platform server optionally returns model selection fields/feature flag. |
cli/internal/runner/runner.go |
Injects model selection-related env vars into the engine process. |
cli/cmd/engine-cli/main.go |
Adds CLI flags to control model selection fields and passes them into mock server/runner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
This looks good to me in general, but question, how is an engine supposed to describe the types of models it cares about or that it is compatible with? |
Author
|
@josebalius That is a good question. We still need the notion of "filtering" here so I will think on how we can do that. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to support model selection (I think optionally) in the new engine SDK. This PR adds support for this.
https://github.com/github/sweagentd/issues/10067