This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Update docker registry to point to docker hub.#488
Open
simonswine wants to merge 1 commit intografana:mainfrom
Open
Update docker registry to point to docker hub.#488simonswine wants to merge 1 commit intografana:mainfrom
simonswine wants to merge 1 commit intografana:mainfrom
Conversation
Most likely a remnant from "before launch" times.
cyriltovena
approved these changes
Jan 25, 2023
Collaborator
cyriltovena
left a comment
cyriltovena
left a comment
There was a problem hiding this comment.
Will that push to dockerhub too in the CI ?
Collaborator
|
Wondering if this fixes grafana/pyroscope#2109 ? |
Collaborator
Author
Good point, it can and maybe it should? What do you think?
I think we might need some lightly different secrets for it, but in theory yes. |
Collaborator
|
I want to push to dockerhub only I think so let's see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most likely a remnant from "before launch" times.