fix: correct datatest to data-testid attribute#433
Open
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Open
fix: correct datatest to data-testid attribute#433MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Conversation
datatest is not recognized by testing tools like Cypress. Updated to standard data-testid attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The Edit Campaign button used a non-standard
datatest=attribute instead of the standarddata-testid=used consistently across the rest of the codebase. The Cypress tests also used[datatest="editbutton"]selectors to match, so the tests passed — but both sides were wrong together.Root cause
Line 18 of ViewCampaign.vue sets
datatest="editbutton"(a made-up attribute). The Cypress tests in campaign.cy.js lines 42 and 55 query[datatest="editbutton"]to match it. Since both sides shared the same non-standard attribute, tests passed. Every other testable element in the codebase usesdata-testid=.Fix
datatest=→data-testid=in ViewCampaign.vue line 18[data-testid="editbutton"]Files changed
frontend/src/components/Campaign/ViewCampaign.vuefrontend/cypress/e2e/campaign.cy.jsHow to verify
data-testid="editbutton"notdatatest="editbutton"Relates to: T415578