fix: correct emit event name to camelCase#434
Open
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Open
fix: correct emit event name to camelCase#434MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Conversation
Vue emits use camelCase internally. Updated event name to reloadCampaignState to match expected listener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
After successfully creating a new round, the campaign view never refreshed automatically. Users had to manually reload the page to see the newly created round.
Root cause
defineEmitson line 233 of RoundNew.vue declares'reloadCampaignState'(camelCase). The parent component ViewCampaign.vue listens with@reloadCampaignState. However all three emit call-sites (lines 384, 426, 431) usedemit('reload-campaign-state')(kebab-case). Vue 3 does not automatically match kebab-case emit names to camelCase listener declarations, so the parent listener never fired.Fix
Changed all three emit call-sites from
emit('reload-campaign-state')→emit('reloadCampaignState').Files changed
frontend/src/components/Round/RoundNew.vueHow to verify
Relates to: T415578