fix: replace router.reload with location.reload#435
Open
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Open
fix: replace router.reload with location.reload#435MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Conversation
Vue Router does not provide reload(). Using location.reload() to properly refresh the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
After deleting a round, the page never refreshed — the deleted round remained visible in the UI even though it had been removed from the database.
Root cause
Line 194 of RoundEdit.vue calls
router.reload()after a successful round deletion. Vue Router does not have areload()method — this throwsTypeError: router.reload is not a functionat runtime. Because the error was thrown inside a.then()callback, it was silently swallowed and the page never refreshed.Fix
Changed
router.reload()→location.reload(), which is the correct browser API for a full page reload. This is consistent with the exact same pattern already used in RoundInfo.vue foractivateRound()andpauseRound().Files changed
frontend/src/components/Round/RoundEdit.vueHow to verify
Relates to: T415578