Skip to content

more units for charts#2004

Open
gingerwizard wants to merge 1 commit intohyperdxio:mainfrom
gingerwizard:more_units
Open

more units for charts#2004
gingerwizard wants to merge 1 commit intohyperdxio:mainfrom
gingerwizard:more_units

Conversation

@gingerwizard
Copy link
Copy Markdown
Contributor

Summary

this adds and extends the number of units that we have available for charts. More specifically, this adds the following units for formatting values on the y-axis.

Data
• bytes(IEC)
• bytes(SI)
• bits(IEC)
• bits(SI)
• kibibytes
• kilobytes
• mebibytes
• megabytes
• gibibytes
• gigabytes
• tebibytes
• terabytes
• pebibytes
• petabytes

Data rate
• packets/sec
• bytes/sec(IEC)
• bytes/sec(SI)
• bits/sec(IEC)
• bits/sec(SI)
• kibibytes/sec
• kibibits/sec
• kilobytes/sec
• kilobits/sec
• mebibytes/sec
• mebibits/sec
• megabytes/sec
• megabits/sec
• gibibytes/sec
• gibibits/sec
• gigabytes/sec
• gigabits/sec
• tebibytes/sec
• tebibits/sec
• terabytes/sec
• terabits/sec
• pebibytes/sec
• pebibits/sec
• petabytes/sec
• petabits/sec

Throughput
• counts/sec (cps)
• ops/sec (ops)
• requests/sec (rps)
• reads/sec (rps)
• writes/sec (wps)
• I/O ops/sec (iops)
• counts/min (cpm)
• ops/min (opm)
• reads/min (rpm)
• writes/min (wpm)

existing units are placed under group level values i.e. "Basic"

Screenshots or video

2026-03-28_17-20-46.mp4

How to test locally or on Vercel

  1. Create a line chart.
  2. Select Display Settings.
  3. Change the units.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 28, 2026

⚠️ No Changeset found

Latest commit: d046c7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

@gingerwizard is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review

  • ⚠️ numericUnit uses z.string().optional() instead of an enum → Any invalid key silently falls through to plain number formatting with no validation error. Consider z.enum([...all valid unit keys...]) to catch typos at schema validation time.

  • ⚠️ reads_sec and rps both produce rps suffix → In NUMERIC_UNIT_CONFIGS, both keys have suffix: 'rps', making them indistinguishable in the chart display. One should use a distinct suffix (e.g. rd/s) or the two options should be merged.

  • ⚠️ openapi.json (1785 lines) appears unrelated to chart units → This brand-new OpenAPI spec for Dashboards/Alerts endpoints was added in the same PR. Confirm this is intentional or split into a separate PR.

  • ✅ Backward compatibility for existing output: 'byte' dashboards (legacy decimalBytes path) is handled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant