Add PATCH /data_connectors/:id to OpenAPI spec#427
Merged
ellicenelson merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
levindixon
approved these changes
Mar 27, 2026
Contributor
levindixon
left a comment
There was a problem hiding this comment.
LGTM! Spec changes, request schema, and error examples are clean and consistent with the existing endpoints. One small suggestion:
Missing "Invalid state" 422 example
The 422 section covers invalid audiences and invalid http_method, but not an invalid state value. Since state is the most consequential field on this endpoint, consider adding:
Invalid state:
value:
type: error.list
request_id: a1b2c3d4-e5f6-7a8b-9c0d-1e2f3a4b5c6d
errors:
- code: parameter_invalid
message: "Invalid state. Must be one of: draft, live"Not a blocker — approving as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
API consumers need documentation for the new update endpoint so they can programmatically update their data connector configurations.
How?
Adds the PATCH endpoint definition and
update_data_connector_requestschema to the Unstable version spec. Field descriptions mirror the existingdata_connector_detailschema for consistency. Also fixes "publish" phrasing to "set to live" in the create endpoint description. Removes the changelog file to follow existing convention (changelog lives in developer-docs, not here).Related
Generated with Claude Code