Fix: resolve issues #498, #499, #447, #504#514
Open
shreyashjagtap157 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: resolve issues #498, #499, #447, #504#514shreyashjagtap157 wants to merge 1 commit intomicrosoft:mainfrom
shreyashjagtap157 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…osoft#504 - Add --skip-gguf flag to avoid forced pip install (fixes microsoft#498, microsoft#499) - Fix sys.exit(1) indentation bug in run_command() (fixes microsoft#447) - Change exit(0) to sys.exit(1) for unsupported arch - Fix ARCH_ALIAS KeyError using .get() for unknown architectures - Add guard for unsupported architectures in parse_args() - Fix same indentation bug in e2e_benchmark.py (fixes microsoft#504)
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple issues related to error handling and optional pip installation in BitNet.
Changes
Issue #498 / #499 - Add --skip-gguf flag
--skip-ggufCLI flag to make GGUF pip installation optionalIssue #447 / #504 - Fix error handling bugs
sys.exit(1)indentation bug inrun_command()- was exiting unconditionallyexit(0)tosys.exit(1)for unsupported architecture (was reporting success on failure)ARCH_ALIASKeyError using.get()for unknown architecturesparse_args()utils/e2e_benchmark.pyTesting
Fixes #498
Fixes #499
Fixes #447
Fixes #504