Conversation
Agent-Logs-Url: https://github.com/microsoft/jericho/sessions/a5ce6115-a872-48e6-9ff0-1b49262d47a7 Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
|
@copilot The max score should be positive though. Look at the code that parses the score. |
…lue) Agent-Logs-Url: https://github.com/microsoft/jericho/sessions/fdbdec46-be7e-4980-87e0-b67709f5fa21 Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
You're right — |
|
@copilot did you ran the walkthrough to check if we are reaching that max_score? |
The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot rebase this branch on top of master branch and try again to play the walkthrough (first the one contained in game_info.py, then the one mentioned in the issue description) |
- Add copilot-setup-steps.yml to set up Python, build tools, jericho, and download game ROMs from BYU-PCCL/z-machine-games - Add copilot-instructions.md with guidance on using ifdb.org for game details, allthingsjacq.com for transcripts, and the game suite for ROMs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/jericho/sessions/dc0365db-f541-4543-ae48-1d627281a5b0 Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
…d transcript Agent-Logs-Url: https://github.com/microsoft/jericho/sessions/b8b2256b-9115-4082-9a9c-7a716c7b6f7c Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/jericho/sessions/b8b2256b-9115-4082-9a9c-7a716c7b6f7c Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Rebased on master (which has the ROMs available) and ran both walkthroughs: Original walkthrough (game_info.py): scored 75/113 — FAIL. It was missing many Club Floyd transcript walkthrough: Using the transcript as a guide, I found 12 additional scoring notes the original walkthrough missed: The Club Floyd run itself reached -113 but missed Updated in commit
|
Afflicted displays scores as negative numbers (tracking infractions), but the
parse_score()function negates the parsed value (score = -strtol(...)), soget_score()returns positive values internally. Jericho was incorrectly reporting a max score of 75, and the walkthrough was incomplete.Changes
frotz/src/games/afflicted.c: Updatedafflicted_max_score()return value from75to117jericho/game_info.py: Updated the walkthrough to include all 27 scoringnoteactions, reaching the true maximum of 117. The original walkthrough only achieved 75/75. The Club Floyd transcript reaches -113 displayed (113 internally), but misses two additional notes (note producein the dining room andnote servingwarein the dish room). The new walkthrough adds 12 notes missing from the original:note roach,note rat,note produce,note dispenser,note mouse,note toilet,note kettle(open steam table lid first),note lettuce(open mini fridge first),note remnants,note pans(walk-in refrigerator),note table(dish racks, before opening dishwasher), andnote servingware.The scoring breakdown: 3 pts (entering restaurant) + 27 notes × 2 pts + 60 pts (body parts/actions) = 117.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.