Open
Conversation
Exercises napi_define_class with method, data value, accessor, and static property descriptors. Includes null-argument tests for napi_define_class via test_null.c/test_null.js. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kraenhansen
force-pushed
the
feat/port-test-constructor
branch
from
b726a69 to
238dd42
Compare
Contributor
Author
|
Rebased and ready for review 👍 |
bavulapati
approved these changes
Mar 29, 2026
bavulapati
left a comment
bavulapati
left a comment
There was a problem hiding this comment.
LGTM
Most of the files are identical. Just the usage of globals instead of required values like assert, loadAddon instead of require, etc.,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
test_constructorfrom the Node.js test suite to the CTS.napi_define_classwith method, value, accessor, and static property descriptorsnapi_define_class(viatest_null.c/test_null.js)test.js,test2.js,test_null.jsTest plan
npm run addons:configure && npm run addons:build— compiles cleanlynpm run node:test— all 58 tests pass (3 new)🤖 Generated with Claude Code