Deprecate ReadBytesKey, ReadErrorKey, WroteBytesKey and WriteErrorKey in favor of semconv keys by Rxfa · Pull Request #8435 · open-telemetry/opentelemetry-go-contrib

Rxfa · 2026-01-19T21:27:30Z

Partial Fix for #8130

…and WriteErrorKey in favor of semconv keys Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

flc1125

Could you add some unit tests for the new attributes

CHANGELOG.md

instrumentation/net/http/otelhttp/handler.go

CHANGELOG.md

Co-authored-by: Flc゛ <i@flc.io>

…o the appropriate section Signed-off-by: rxfa <rafa3rnrn@gmail.com>

…and the new semconv read/write attributes Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

…d entries Signed-off-by: rxfa <rafa3rnrn@gmail.com>

flc1125

After this adjustment, LGTM.

instrumentation/net/http/otelhttp/handler_test.go

instrumentation/net/http/otelhttp/common.go

CHANGELOG.md

…TTP attribute keys instead of helpers Signed-off-by: rxfa <rafa3rnrn@gmail.com>

…30-deprecate-otelhttp

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

codecov · 2026-01-26T08:50:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (b228c0f) to head (6151963).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #8435   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files        182     182           
  Lines      13766   13774    +8     
=====================================
+ Hits       11316   11326   +10     
- Misses      2048    2049    +1     
+ Partials     402     399    -3

Files with missing lines	Coverage Δ
instrumentation/net/http/otelhttp/common.go	`100.0% <ø> (ø)`
instrumentation/net/http/otelhttp/handler.go	`97.5% <100.0%> (+5.4%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MrAlias · 2026-02-19T17:43:08Z

@Rxfa are you still able to work on this?

Rxfa · 2026-02-23T14:24:52Z

@Rxfa are you still able to work on this?

Hey, I'm still able to work on this.

I believe I addressed all feedback, and I'm awaiting further instructions if there's a reason for the PR not to be approved and merged.

flc1125 · 2026-02-24T11:12:17Z

@Rxfa Please resolve the conflicts and make sure the CI passes.

flc1125 · 2026-02-25T14:40:16Z

@Rxfa PTAL, The change log needs to be located below the "Unreleased" section.

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

pellared · 2026-03-04T11:23:59Z

@Rxfa, sorry for inconvenience, but can I ask you again to resolve the conflicts and make sure the CI passes?

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Rxfa · 2026-03-06T03:13:47Z

@Rxfa, sorry for inconvenience, but can I ask you again to resolve the conflicts and make sure the CI passes?

It should be fixed now.

CHANGELOG.md

instrumentation/net/http/otelhttp/common.go

pellared · 2026-03-06T15:02:05Z

CHANGELOG.md

 ### Added

 - Add environment variables propagation carrier in `go.opentelemetry.io/contrib/propagators/envcar`. (#8442)
+- Added semantic convention attribute keys `HTTPRequestBodySizeKey`,


This should be two entries, one "Changed" that we are emitting "x.y" instead of "a.b" per semantic conventions, second "Deprecated" about the deprecation of the constants

Regarding the entry under "Changed", you mean something similar to what can be seen here?

Similar to

opentelemetry-go-contrib/CHANGELOG.md

Lines 121 to 127 in b228c0f

- The semantic conventions v1.39.0 release introduces breaking changes, including:

- `rpc` span and metric attributes have been renamed to align with naming guidelines:

- `rpc.system` → `rpc.system.name` (values: `grpc`, `grpc_web`, `connectrpc`, `thrift`, `dubbo`, etc.)

- `rpc.method` and `rpc.service` have been merged into a fully-qualified `rpc.method` attribute

- `rpc.client|server.duration` → `rpc.client|server.call.duration` (unit changed to seconds)

- `rpc.grpc.request.metadata`/`rpc.grpc.response.metadata` → `rpc.request.metadata`/`rpc.response.metadata`

- `rpc.grpc.status_code` → deprecated in favor of `rpc.response.status_code`

Just pushed a commit addressing this. Please LMK if it looks good now

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

…30-deprecate-otelhttp

…from "added" to "changed" and "deprecated" Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

…30-deprecate-otelhttp

chore(otelhttp): Deprecate ReadBytesKey, ReadErrorKey, WroteBytesKey …

e3f2043

…and WriteErrorKey in favor of semconv keys Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Rxfa requested review from a team and dmathieu as code owners January 19, 2026 21:27

docs(Changelog): deprecate HTTP read/write attribute keys

1c6edc2

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

flc1125 reviewed Jan 20, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

instrumentation/net/http/otelhttp/handler.go Outdated Show resolved Hide resolved

instrumentation/net/http/otelhttp/handler.go Outdated Show resolved Hide resolved

flc1125 reviewed Jan 20, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Rxfa and others added 5 commits January 20, 2026 17:45

Apply suggestions from code review

d33e12c

Co-authored-by: Flc゛ <i@flc.io>

docs(Changelog): move deprecation of HTTP read/write attribute keys t…

3c618d2

…o the appropriate section Signed-off-by: rxfa <rafa3rnrn@gmail.com>

chore: write unit test to making sure that spans contain both legacy …

eddf4c3

…and the new semconv read/write attributes Signed-off-by: rxfa <rafa3rnrn@gmail.com>

fix: Wrong attribute being emitted in span in case of a write event

2e5eba4

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

docs(Changelog): separate otelhttp semconv additions from deprecate…

fa314d8

…d entries Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Rxfa requested a review from flc1125 January 21, 2026 21:44

flc1125 approved these changes Jan 22, 2026

View reviewed changes

instrumentation/net/http/otelhttp/handler_test.go Outdated Show resolved Hide resolved

Merge branch 'main' into 8130-deprecate-otelhttp

2a13f78

pellared added this to the v1.40.0 milestone Jan 23, 2026

pellared reviewed Jan 23, 2026

View reviewed changes

instrumentation/net/http/otelhttp/common.go Show resolved Hide resolved

pellared reviewed Jan 23, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Rxfa added 3 commits January 23, 2026 19:31

chore(otelhttp): change read/write attributes test to assert on raw H…

943e27d

…TTP attribute keys instead of helpers Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Merge remote-tracking branch 'origin/8130-deprecate-otelhttp' into 81…

a9a97e1

…30-deprecate-otelhttp

docs(changelog): Improve clarity of newly added changelog entries

d799e90

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

MrAlias modified the milestones: v1.40.0, v1.41.0 Jan 29, 2026

Merge branch 'main' into 8130-deprecate-otelhttp

ee0a4a4

MrAlias modified the milestones: v1.41.0, v1.42.0 Feb 26, 2026

Rxfa and others added 2 commits February 26, 2026 21:34

docs(changelog): Fix change log entry under the wrong section

5c6b334

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Merge branch 'main' into 8130-deprecate-otelhttp

84cbf8a

Rxfa and others added 2 commits March 6, 2026 02:28

Merge branch 'main' into 8130-deprecate-otelhttp

dce251d

chore: Fix linter issues

fd4dc6d

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

move changelog entry up to the unreleased section

13410af

dmathieu reviewed Mar 6, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestion from @dmathieu

cd0fe88

dmathieu reviewed Mar 6, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestion from @dmathieu

6cae925

dmathieu approved these changes Mar 6, 2026

View reviewed changes

Merge branch 'main' into 8130-deprecate-otelhttp

6151963

dmathieu requested a review from pellared March 6, 2026 12:54

dashpole reviewed Mar 6, 2026

View reviewed changes

instrumentation/net/http/otelhttp/common.go Outdated Show resolved Hide resolved

dashpole reviewed Mar 6, 2026

View reviewed changes

instrumentation/net/http/otelhttp/common.go Outdated Show resolved Hide resolved

pellared reviewed Mar 6, 2026

View reviewed changes

Rxfa added 6 commits March 6, 2026 15:28

fix: correct semconv package in deprecation comments

595fdfe

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Merge remote-tracking branch 'origin/8130-deprecate-otelhttp' into 81…

016647d

…30-deprecate-otelhttp

docs(changelog): break changes into two different changelog entries (…

6d9c66c

…from "added" to "changed" and "deprecated" Signed-off-by: rxfa <rafa3rnrn@gmail.com>

fix: Correct changelog entries under wrong section

a2bac74

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

fix: Correct changelog entries under wrong section

ea56859

Signed-off-by: rxfa <rafa3rnrn@gmail.com>

Merge remote-tracking branch 'origin/8130-deprecate-otelhttp' into 81…

deaaba0

…30-deprecate-otelhttp

pellared modified the milestones: v1.42.0, v1.43.0 Mar 6, 2026

	- The semantic conventions v1.39.0 release introduces breaking changes, including:
	- `rpc` span and metric attributes have been renamed to align with naming guidelines:
	- `rpc.system` → `rpc.system.name` (values: `grpc`, `grpc_web`, `connectrpc`, `thrift`, `dubbo`, etc.)
	- `rpc.method` and `rpc.service` have been merged into a fully-qualified `rpc.method` attribute
	- `rpc.client\|server.duration` → `rpc.client\|server.call.duration` (unit changed to seconds)
	- `rpc.grpc.request.metadata`/`rpc.grpc.response.metadata` → `rpc.request.metadata`/`rpc.response.metadata`
	- `rpc.grpc.status_code` → deprecated in favor of `rpc.response.status_code`

Conversation

Rxfa commented Jan 19, 2026

Uh oh!

flc1125 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flc1125 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MrAlias commented Feb 19, 2026

Uh oh!

Rxfa commented Feb 23, 2026

Uh oh!

flc1125 commented Feb 24, 2026

Uh oh!

flc1125 commented Feb 25, 2026

Uh oh!

pellared commented Mar 4, 2026

Uh oh!

Rxfa commented Mar 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Rxfa Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pellared Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Rxfa Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flc1125 left a comment •

edited

Loading

codecov bot commented Jan 26, 2026 •

edited

Loading

Rxfa Mar 6, 2026 •

edited

Loading