feat(BulkSelect): add internationalization (i18n) support

[rhamilto]

Summary

• Fixes BulkSelect: Add internationalization (i18n) support #895
• Adds optional props for customizing all user-facing strings in BulkSelect
• Maintains full backward compatibility with sensible English defaults

Details

Applications using BulkSelect that need to support non-English languages or custom terminology can now provide custom labels for all user-facing strings.

New Props

All props are optional with English defaults:

• selectNoneLabel: Custom label for "Select none" option (default: "Select none (0)")
• selectPageLabel: Function receiving pageCount to format "Select page" label (default: `Select page${pageCount ? ` (${pageCount})` : ''}`)
• selectAllLabel: Function receiving totalCount to format "Select all" label (default: `Select all${totalCount ? ` (${totalCount})` : ''}`)
• selectedLabel: Function receiving selectedCount to format the displayed count (default: `${selectedCount} selected`)

Example Usage

import { useTranslation } from 'react-i18next';

const MyComponent = () => {
  const { t } = useTranslation();
  
  return (
    <BulkSelect
      selectedCount={5}
      totalCount={100}
      pageCount={20}
      onSelect={handleSelect}
      selectNoneLabel={t('bulkSelect.selectNone')}
      selectPageLabel={(pageCount) => t('bulkSelect.selectPage', { pageCount })}
      selectAllLabel={(totalCount) => t('bulkSelect.selectAll', { totalCount })}
      selectedLabel={(selectedCount) => t('bulkSelect.selected', { selectedCount })}
    />
  );
};

Note: Parameter names (pageCount, totalCount, selectedCount) are deliberately chosen to avoid conflicts with i18n reserved keywords like count used for pluralization.

Test plan

• All existing tests pass (backward compatibility maintained)
• Added new test with French labels to verify i18n functionality
• Build completes successfully
• No breaking changes - existing usage works exactly as before
• Parameter names avoid i18n reserved keyword conflicts

🤖 Generated with Claude Code

[patternfly-build]

Preview: https://react-component-groups-pr-component-groups-896.surge.sh

A11y report: https://react-component-groups-pr-component-groups-896-a11y.surge.sh

[nicolethoen]

One issue: useMemo invalidation on every render.

The default values for selectPageLabel, selectAllLabel, and selectedLabel are inline arrow functions in the destructuring:

  selectPageLabel = (pageCount?: number) => `Select page${pageCount ? ` (${pageCount})` : ''}`,                                
  selectAllLabel = (totalCount?: number) => `Select all${totalCount ? ` (${totalCount})` : ''}`,            

These create new function references on every render, even when the consumer doesn't pass custom labels. Since they're added
to the useMemo dependency array, the memoization of dropdown items is effectively broken — it will recompute every render
instead of only when pageCount/totalCount change.

Fix: Hoist the defaults to module-level constants:

  const defaultSelectPageLabel = (pageCount?: number) => `Select page${pageCount ? ` (${pageCount})` : ''}`;                   
  const defaultSelectAllLabel = (totalCount?: number) => `Select all${totalCount ? ` (${totalCount})` : ''}`;                  
  const defaultSelectedLabel = (count: number) => `${count} selected`;                                                         
                                                                                                                               
  export const BulkSelect: FC<BulkSelectProps> = ({                                                                            
    // ...other props                                                                                                          
    selectNoneLabel = 'Select none (0)',                                                                                       
    selectPageLabel = defaultSelectPageLabel,                                                                                  
    selectAllLabel = defaultSelectAllLabel,                                                                                    
    selectedLabel = defaultSelectedLabel,                                                                                      
    ...props                                                                                                                   
  }: BulkSelectProps) => {                                                                                                     
    // rest of component unchanged