gh-146541: Allow building the Android testbed for 32-bit targets#146542
Open
robertkirkman wants to merge 2 commits intopython:mainfrom
Open
gh-146541: Allow building the Android testbed for 32-bit targets#146542robertkirkman wants to merge 2 commits intopython:mainfrom
robertkirkman wants to merge 2 commits intopython:mainfrom
Conversation
This allows building the Android testbed for 32-bit targets using the prebuilt 32-bit dependencies that are already available here: https://github.com/beeware/cpython-android-source-deps/releases , adding the target triplets to match them, `arm-linux-androideabi` and `i686-linux-android`. This also adds the `arm` key to the dictionary used to convert the `machine` variable to an Android ABI in `sysconfig.get_platform()`, because when the Android testbed is being cross-compiled, it stores the contents of the first substring of `_PYTHON_HOST_PLATFORM` before the first `-` symbol in the `machine` variable, which the dictionary does not currently handle.
robertkirkman
requested review from
FFY00,
freakboy3742 and
mhsmith
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows building the Android testbed for 32-bit targets using the prebuilt 32-bit dependencies that are already available here: https://github.com/beeware/cpython-android-source-deps/releases , adding the target triplets to match them,
arm-linux-androideabiandi686-linux-android.This also adds the
armkey to the dictionary used to convert themachinevariable to an Android ABI insysconfig.get_platform(), because when the Android testbed is being cross-compiled, it stores the contents of the first substring of_PYTHON_HOST_PLATFORMbefore the first-symbol in themachinevariable, which the dictionary does not currently handle.