Open
Conversation
Member
jweiser
commented
Mar 27, 2026
jweiser
commented
- updates batik version to deal with SVG without offset attribute on stop elements
- moves font files under src/main/resources
- adds plugin to stop filtering font files
EliotRagueneau
requested changes
Mar 27, 2026
Contributor
EliotRagueneau
left a comment
EliotRagueneau
left a comment
There was a problem hiding this comment.
Just move batik and fop versions to reactome-parent, but otherwise looks good :D
|
|
||
| <properties></properties> | ||
| <properties> | ||
| <batik.version>1.18</batik.version> |
Contributor
There was a problem hiding this comment.
Should be defined in reactome-parent if you want to make things cleanly
adamjohnwright
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.