PR: Clean up the Qt namespace and add the tests#465
Open
StSav012 wants to merge 11 commits intospyder-ide:masterfrom
Open
PR: Clean up the Qt namespace and add the tests#465StSav012 wants to merge 11 commits intospyder-ide:masterfrom
StSav012 wants to merge 11 commits intospyder-ide:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I'm unhappy with the auto-fix.
dalthviz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to resolve #463 in case it even needs resolving.
Some changes are tricky and require further testing. Namely, please pay attention to
QApplication.exec_andQMenu.exec_functions when they're patched. My local tests reveal no problems, but…