Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the ToolHive documentation to reflect user-facing features shipped in v0.12.3–v0.13.0, aligning guides and concept pages with current CRD/CLI capabilities (scaling, auth, composite workflows, and skills install).
Changes:
- Document tool annotation overrides for aggregated tools (vMCP).
- Rewrite scaling guidance to cover new
replicas/backendReplicasfields and session storage requirements. - Add docs for
forEachcomposite-tool steps and for installing skills viathv skill install(registry + git sources), plus cross-references between guides.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/toolhive/guides-vmcp/tool-aggregation.mdx | Adds annotation override documentation and example configuration. |
| docs/toolhive/guides-vmcp/scaling-and-performance.mdx | Updates horizontal scaling guidance and adds session storage + MCPServer scaling sections. |
| docs/toolhive/guides-vmcp/composite-tools.mdx | Documents forEach iteration steps and expands template context table. |
| docs/toolhive/guides-registry/skills.mdx | Adds CLI-based skill installation instructions and flags table. |
| docs/toolhive/guides-k8s/run-mcp-k8s.mdx | Adds cross-link to scaling guidance for MCPServer replicas. |
| docs/toolhive/guides-k8s/redis-session-storage.mdx | Adds scaling-related context and links session storage to horizontal scaling. |
| docs/toolhive/guides-k8s/auth-k8s.mdx | Updates upstream provider note to reflect multi-upstream support in VirtualMCPServer. |
| docs/toolhive/concepts/skills.mdx | Updates current status to reflect CLI install support and links to guide. |
| docs/toolhive/concepts/backend-auth.mdx | Replaces “single upstream” language with multi-upstream (vMCP) + clarifies MCPServer limitations. |
| This guide explains how to scale MCPServer and Virtual MCP Server (vMCP) | ||
| deployments. |
There was a problem hiding this comment.
The guide now claims it covers both MCPServer and Virtual MCP Server, but the vertical scaling section/examples still only describe VirtualMCPServer (podTemplateSpec with vmcp container). Either add the MCPServer equivalent (its podTemplateSpec uses the mcp container) or adjust the intro/description to avoid implying full MCPServer coverage for vertical scaling.
There was a problem hiding this comment.
+1, adding MCPServer scaling to this guide seems out of place since this is specifically inside the vMCP section. If horizontal scaling for MCPServer is now supported, it seems like a scaling guide is called for in the main operator section, or a new section in the guides-k8s/run-mcp-k8s guide?
| | Field | Description | Default | | ||
| | --------------- | --------------------------------------------------- | ------- | | ||
| | `collection` | Template expression that produces an array | — | | ||
| | `itemVar` | Variable name for the current item | — | | ||
| | `maxParallel` | Maximum concurrent iterations (max 50) | 10 | | ||
| | `maxIterations` | Maximum total iterations (max 1000) | 100 | | ||
| | `step` | Inner step definition (tool call to execute per item) | — | | ||
| | `onError` | Error handling: `abort` (stop) or `continue` (skip) | abort | |
There was a problem hiding this comment.
The forEach fields table is inconsistent with the generated CRD reference (docs/toolhive/reference/crd-spec.md): collection should be described as resolving to a JSON array or slice; itemVar defaults to "item" (not required); and maxParallel/maxIterations caps/defaults should match the reference (only maxIterations is documented as hard-capped at 1000). Updating this table will prevent users from configuring fields incorrectly.
| | Field | Description | Default | | |
| | --------------- | --------------------------------------------------- | ------- | | |
| | `collection` | Template expression that produces an array | — | | |
| | `itemVar` | Variable name for the current item | — | | |
| | `maxParallel` | Maximum concurrent iterations (max 50) | 10 | | |
| | `maxIterations` | Maximum total iterations (max 1000) | 100 | | |
| | `step` | Inner step definition (tool call to execute per item) | — | | |
| | `onError` | Error handling: `abort` (stop) or `continue` (skip) | abort | | |
| | Field | Description | Default | | |
| | --------------- | ----------------------------------------------------------- | ------- | | |
| | `collection` | Template expression that resolves to a JSON array or slice | — | | |
| | `itemVar` | Variable name for the current item | item | | |
| | `maxParallel` | Maximum concurrent iterations | 10 | | |
| | `maxIterations` | Maximum total iterations (hard cap 1000) | 100 | | |
| | `step` | Inner step definition (tool call to execute per item) | — | | |
| | `onError` | Error handling: `abort` (stop) or `continue` (skip) | abort | |
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
b9da28d to
de415e8
Compare
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
de415e8 to
bfecf66
Compare
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
bfecf66 to
7a9131f
Compare
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
7a9131f to
46d40ca
Compare
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
46d40ca to
d4c8244
Compare
danbarr
left a comment
danbarr
left a comment
There was a problem hiding this comment.
As noted on Copilot's review comment, the new content about scaling MCPServer resources is out of place in the vMCP scaling/performance guide.
It should live with the other MCPServer docs in the main operator section - either as a new guide if the amount of content warrants it, or in the existing "Run MCP servers in Kubernetes" guide.
| This guide explains how to scale MCPServer and Virtual MCP Server (vMCP) | ||
| deployments. |
There was a problem hiding this comment.
+1, adding MCPServer scaling to this guide seems out of place since this is specifically inside the vMCP section. If horizontal scaling for MCPServer is now supported, it seems like a scaling guide is called for in the main operator section, or a new section in the guides-k8s/run-mcp-k8s guide?
Catch up documentation with features shipped in v0.12.3 through v0.13.0. Auto-generated CLI/CRD reference docs were already current; these changes cover manual doc updates verified against source code at each release tag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rdimitrov
force-pushed
the
update-docs-for-v0.12.3-v0.13.0
branch
from
d4c8244 to
2abd168
Compare
|
@danbarr - I think I addressed the feedback so it should be ready for another round 👍 |
The updated locations of the scaling info make sense to me now. I'll clear my "changes requested" review and leave it to the platform team to do their technical review. |
Summary
Catch up documentation with user-facing features shipped in ToolHive v0.12.3 through v0.13.0. Changes were verified against source code at each release tag.
replicasandbackendReplicasCRD fields, session storage config, and stdio transport limitationsthv skill installdocumentation (registry and git sources)Releases covered
Excluded (verified as not needing docs)
--publishflag (not present in CLI at v0.13.0)Test plan
npm run buildpasses with no broken links or MDX errors🤖 Generated with Claude Code