Fix KeyError in _remove_buddy by safely handling missing buddy keys#1090
Open
AYUSH676-JARVIS wants to merge 3 commits intosugarlabs:masterfrom
Open
Fix KeyError in _remove_buddy by safely handling missing buddy keys#1090AYUSH676-JARVIS wants to merge 3 commits intosugarlabs:masterfrom
AYUSH676-JARVIS wants to merge 3 commits intosugarlabs:masterfrom
Conversation
Author
|
Fixes #840 |
Author
|
Hi, I have submitted a PR fixing the KeyError and improving buddy state consistency. Would appreciate feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KeyError in _remove_buddy in meshbox.py.
The crash occurs when buddy_model.props.key is not present in the _buddies dictionary. This PR adds a safe check and logging to handle the situation gracefully and prevent crashes during inconsistent Telepathy states.