Open
Conversation
|
Contributor
|
Rounding of numbers can be done in binary or in decimal. The ECMA-402 rounding modes are designed for use in decimal rounding. They should always be available when rounding a decimal and should never be available when rounding a float. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some consideration, and in response to concerns raised by @waldemarhorwat at the plenary, I think we should drop
roundingModeas a constructor or.convertTo()option, and instead always use round-ties-to-even.This would match what the rest of ECMA-262 is doing, and avoid the problems caused by truncation. This would not prohibit the definition and use of rounding mode as a formatting option, either in the Intl.NumberFormat constructor options, or in Amount's
.toLocaleString()options.