chore: upgrade action runtime from node20 to node24#237
chore: upgrade action runtime from node20 to node24#237wataboru wants to merge 3 commits intovn7n24fzkq:mainfrom
Conversation
Node.js 20 actions are deprecated and will be forced to run on Node.js 24 starting June 2nd, 2026. Since package.json already specifies `engines.node: "22.x"`, the codebase is compatible. See: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughBumped Node.js/runtime versions across CI and package metadata: GitHub Action runtime in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@action.yml`:
- Line 33: The GitHub Action runtime declaration ('using' in action.yml
currently set to 'node24') is mismatched with the repository's Node 22 setup; to
fix, decide to target Node 24 and update the runtime and artifacts or revert the
action to Node 22. If moving to Node 24: change 'using' in action.yml to
'node24' (keep as-is), then update .node-version to 24.14.0, set package.json
engines.node to "24.x", rebuild dist/index.js with Node 24, and run CI tests
(test-and-lint.yml and manual-release.yml) under Node 24 to confirm
compatibility. If staying on Node 22: change 'using' in action.yml to 'node22',
leaving .node-version and package.json as 22.x, rebuild dist/index.js with Node
22, and ensure workflows use Node 22 for tests/releases. Ensure the same Node
major version is used across 'using' (action.yml), .node-version, package.json
engines.node, dist build, and CI workflows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
- Update .node-version from 22.13.0 to 24.14.0 - Update package.json engines.node from "22.x" to "24.x" - Update CI workflows to use actions/checkout@v5 and actions/setup-node@v5 - Rebuild dist/index.js with Node 24 - All tests pass on Node 24+
Summary
action.ymlruntime fromnode20tonode24.node-versionfrom22.13.0to24.14.0package.jsonengines.nodefrom"22.x"to"24.x"test-and-lint.yml,manual-release.yml) to useactions/checkout@v5andactions/setup-node@v5package-lock.jsonNode.js 20 actions are deprecated and will be forced to run on Node.js 24 starting June 2nd, 2026.
References
Test plan
npm run build— passesnpm run package—dist/index.jsrebuilt (no diff, ncc output is Node-version-independent)npm run test— all 21 tests pass on Node 25 (superset of Node 24)FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=truein my own workflowSummary by CodeRabbit