Skip to content

chore: upgrade action runtime from node20 to node24#237

Open
wataboru wants to merge 3 commits intovn7n24fzkq:mainfrom
wataboru:chore/upgrade-node20-to-node24
Open

chore: upgrade action runtime from node20 to node24#237
wataboru wants to merge 3 commits intovn7n24fzkq:mainfrom
wataboru:chore/upgrade-node20-to-node24

Conversation

@wataboru
Copy link
Copy Markdown

@wataboru wataboru commented Mar 26, 2026

Summary

  • Update action.yml runtime from node20 to node24
  • Update .node-version from 22.13.0 to 24.14.0
  • Update package.json engines.node from "22.x" to "24.x"
  • Update CI workflows (test-and-lint.yml, manual-release.yml) to use actions/checkout@v5 and actions/setup-node@v5
  • Update package-lock.json

Node.js 20 actions are deprecated and will be forced to run on Node.js 24 starting June 2nd, 2026.

References

Test plan

  • npm run build — passes
  • npm run packagedist/index.js rebuilt (no diff, ncc output is Node-version-independent)
  • npm run test — all 21 tests pass on Node 25 (superset of Node 24)
  • Verified the action runs successfully with FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true in my own workflow

Summary by CodeRabbit

  • Chores
    • Bumped Node.js runtime across the project to v24 (tooling, runtime declarations, and action runtime).
    • Updated CI/release workflows to use newer major action versions (checkout and Node setup moved to v5).
    • Aligned workflow step labels and normalized whitespace for consistency.

Node.js 20 actions are deprecated and will be forced to run on
Node.js 24 starting June 2nd, 2026. Since package.json already
specifies `engines.node: "22.x"`, the codebase is compatible.

See: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6dc3a8a-4125-48e5-91ac-efb69e442a82

📥 Commits

Reviewing files that changed from the base of the PR and between b6f0245 and 4ec4dc8.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • .github/workflows/manual-release.yml
  • .github/workflows/test-and-lint.yml
  • .node-version
  • package.json
✅ Files skipped from review due to trivial changes (4)
  • package.json
  • .node-version
  • .github/workflows/manual-release.yml
  • .github/workflows/test-and-lint.yml

📝 Walkthrough

Walkthrough

Bumped Node.js/runtime versions across CI and package metadata: GitHub Action runtime in action.yml from node20node24, workflow actions and setup-node versions updated, .node-version set to 24.14.0, and package.json engines.node changed to 24.x.

Changes

Cohort / File(s) Summary
Action runtime
action.yml
Updated runs.using from node20 to node24 (entry main: dist/index.js unchanged).
Workflows
.github/workflows/manual-release.yml, .github/workflows/test-and-lint.yml
Bumped actions/checkout and actions/setup-node usages from @v4@v5; updated step label to reference Node.js 24 and normalized minor whitespace.
Node/version metadata
.node-version, package.json
Updated .node-version to 24.14.0 and package.json engines.node from 22.x24.x.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

hacktoberfest-accepted

Poem

🐰 A rabbit hops from twenty to four and more,
I nudge the runtimes, tidy up the core,
Workflows aligned, versions set to shine,
A tiny patch—now everything's in line. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading the action runtime from Node 20 to Node 24, which is the primary objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@action.yml`:
- Line 33: The GitHub Action runtime declaration ('using' in action.yml
currently set to 'node24') is mismatched with the repository's Node 22 setup; to
fix, decide to target Node 24 and update the runtime and artifacts or revert the
action to Node 22. If moving to Node 24: change 'using' in action.yml to
'node24' (keep as-is), then update .node-version to 24.14.0, set package.json
engines.node to "24.x", rebuild dist/index.js with Node 24, and run CI tests
(test-and-lint.yml and manual-release.yml) under Node 24 to confirm
compatibility. If staying on Node 22: change 'using' in action.yml to 'node22',
leaving .node-version and package.json as 22.x, rebuild dist/index.js with Node
22, and ensure workflows use Node 22 for tests/releases. Ensure the same Node
major version is used across 'using' (action.yml), .node-version, package.json
engines.node, dist build, and CI workflows.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a10876bb-abd5-43e5-88ab-453e2dd0c6a0

📥 Commits

Reviewing files that changed from the base of the PR and between f092803 and b6f0245.

📒 Files selected for processing (1)
  • action.yml

- Update .node-version from 22.13.0 to 24.14.0
- Update package.json engines.node from "22.x" to "24.x"
- Update CI workflows to use actions/checkout@v5 and actions/setup-node@v5
- Rebuild dist/index.js with Node 24
- All tests pass on Node 24+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant