Throw "invalid cookie domain" as its definition implies

[yezhizhen]

See servo/servo#43690 (comment)

The definition of InvalidCookieDomain is: An illegal attempt was made to set a cookie under a different domain than the current page.

But somehow, the spec asks to throw "invalid argument" error for this case.
However, all browsers indeed throw "invalid cookie domain" for this case.

Following test aligns with current spec, yet fails for all browsers.

def test_add_cookie_with_domain_not_matching_current_domain(session, url):
    session.url = url("/common/blank.html")

    new_cookie = {
        "name": "hello",
        "value": "world",
        "domain": "example.com",
        "path": "/",
        "httpOnly": False,
        "secure": False
    }

    response = add_cookie(session, new_cookie)
    assert_error(response, "invalid argument")

---

This change is 

---

Preview | Diff

[yezhizhen]

cc @whimboo @xiaochengh

[whimboo]

This makes sense. Thanks for discovering that discrepancy. The referenced tests can be found here but I have to add that we only test unsupported schemes for invalid cookie domain. We should indeed at least one more test with a valid domain. @yezhizhen mind adding one respectively? Thanks!

[yezhizhen]

Adding one more in web-platform-tests/wpt#58801