Include NoVarySearch Match for PrerenderNewTabHandle#58803
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Include NoVarySearch Match for PrerenderNewTabHandle#58803chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Same tab prerender for speculationrules uses URL match with No Vary Search, but for new tab _blank target, it is using an exact URL match. This CL updates PrerenderNewTabHandle to use the same matching. Updated TestExpectations with same expected failure in _self target. Bug: 495864172 Change-Id: Ic3c636fb14be3f42fb716bdda07b145eeffd143d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same tab prerender for speculationrules uses URL match with No Vary
Search, but for new tab _blank target, it is using an exact URL match.
This CL updates PrerenderNewTabHandle to use the same matching. Updated
TestExpectations with same expected failure in _self target.
Bug: 495864172
Change-Id: Ic3c636fb14be3f42fb716bdda07b145eeffd143d
Reviewed-on: https://chromium-review.googlesource.com/7702915
WPT-Export-Revision: 3900574bac390d9e1a45cee38fbc5be708102d6c