[soft-navs] Change ICP entry to use global NavId.#58826
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
[soft-navs] Change ICP entry to use global NavId.#58826chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
When emitting a new InteractionContentfulPaint, we should use the current global NavigationId value, rather than try to use the navigation*id* that was assigned for the context. This is because context's start without a navigation id, and may never get one, for interactions that are not navigations. Also, the expected behaviour of navigationid is that it represents the "performance timeline slice" rather than the specific interaction context this paint is attributed for. Bug: 496588835 Change-Id: I55e0b1935dcb53a3a51a5bc3ab03717d6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emitting a new InteractionContentfulPaint, we should use the
current global NavigationId value, rather than try to use the
navigationid that was assigned for the context. This is because
context's start without a navigation id, and may never get one, for
interactions that are not navigations.
Also, the expected behaviour of navigationid is that it represents the
"performance timeline slice" rather than the specific interaction
context this paint is attributed for.
Bug: 496588835
Change-Id: I55e0b1935dcb53a3a51a5bc3ab03717d6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/7704133
WPT-Export-Revision: 6b7e6174cad5d4fe0038a9b667b85e4432388117