fix: add --skip-gguf flag to avoid forced pip install#499
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add --skip-gguf flag to avoid forced pip install#499Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Add optional --skip-gguf flag to make GGUF pip installation optional - Default behavior unchanged (installs if flag not set) - Useful for custom venvs, CI pipelines, and docker environments - Resolves: environment conflicts from forced pip installation Fixes microsoft#498
shreyashjagtap157
added a commit
to shreyashjagtap157/BitNet
that referenced
this pull request
Mar 28, 2026
…osoft#504 - Add --skip-gguf flag to avoid forced pip install (fixes microsoft#498, microsoft#499) - Fix sys.exit(1) indentation bug in run_command() (fixes microsoft#447) - Change exit(0) to sys.exit(1) for unsupported arch - Fix ARCH_ALIAS KeyError using .get() for unknown architectures - Add guard for unsupported architectures in parse_args() - Fix same indentation bug in e2e_benchmark.py (fixes microsoft#504)
shreyashjagtap157
added a commit
to shreyashjagtap157/BitNet
that referenced
this pull request
Mar 28, 2026
…osoft#504 - Add --skip-gguf flag to avoid forced pip install (fixes microsoft#498, microsoft#499) - Fix sys.exit(1) indentation bug in run_command() (fixes microsoft#447) - Change exit(0) to sys.exit(1) for unsupported arch - Fix ARCH_ALIAS KeyError using .get() for unknown architectures - Add guard for unsupported architectures in parse_args() - Fix same indentation bug in e2e_benchmark.py (fixes microsoft#504)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
--skip-ggufflag to setup_env.py to make GGUF pip installation optional, preventing environment conflicts in custom venvs, CI pipelines, and docker environments.Changes
--skip-ggufargument to argparseskipparameter--skip-ggufis set, the pip install is skipped with a log messageUse Cases
Testing
Tested locally by:
python setup_env.py --skip-gguf ...- correctly skips installationpython setup_env.py ...without flag - maintains existing behaviorFixes #498